device/bluetooth: Implemented UriBeacon decoder.

device/bluetooth/uribeacon/uri_encoder.h

+// Copyright (c) 2015 The Chromium Authors. All rights reserved.

[armansito, 2015/02/24 23:55:08]

nit: Drop the '(c)' bit.

[dvh, 2015/02/25 23:52:13]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef DEVICE_BLUETOOTH_URIBEACON_URI_ENCODER_H_
+#define DEVICE_BLUETOOTH_URIBEACON_URI_ENCODER_H_
+
+#include <string>
+
+#include "base/strings/string_piece.h"
+
+namespace device {
+
+// Encodes the input string using URI encoding described in UriBeacon
+// specifications.

[armansito, 2015/02/24 23:55:07]

I would probably add a comment-block at the top of this file that describes how
to use these utility functions (similar to src/base/ headers), to demonstrate
what kind of input-output data is expected.

[dvh, 2015/03/03 20:26:04]

Done.

+void EncodeUriBeaconUri(const base::StringPiece& input, std::string* output);

[armansito, 2015/02/24 23:55:08]

I guess string -> string works as the general data type but it might be more
suitable to represent the encoded format as std::vector<uint8_t> instead, which
makes it more explicit that this is a series of bytes. It would also be more
consistent with other places in device/bluetooth.

[dvh, 2015/03/03 20:26:03]

Done.

+
+// Decodes the input string using URI encoding described in UriBeacon
+// specifications.
+void DecodeUriBeaconUri(const base::StringPiece& input, std::string* output);
+
+}  // namespace device
+
+#endif