Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 950073002: Make the stocks app slightly prettier. (Closed)

Created:
5 years, 10 months ago by eseidel
Modified:
5 years, 10 months ago
Reviewers:
rafaelw
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make the stocks app slightly prettier. I removed the green background and added display of percent change (which is random for now). I also display a random assortment of stocks every time instead of always the top 100. R=rafaelw@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/4b92a16ce28f853a337382c66bb6fde4b4570353

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -7 lines) Patch
M sky/examples/stocks/companylist.sky View 3 chunks +5 lines, -0 lines 0 comments Download
M sky/examples/stocks/stock.sky View 1 chunk +30 lines, -3 lines 0 comments Download
M sky/examples/stocks/stocks.sky View 4 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
eseidel
5 years, 10 months ago (2015-02-23 21:06:27 UTC) #1
rafaelw
lgtm
5 years, 10 months ago (2015-02-23 21:09:26 UTC) #3
eseidel
5 years, 10 months ago (2015-02-23 21:09:45 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4b92a16ce28f853a337382c66bb6fde4b4570353 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698