mojo/dart/embedder/dart_controller.cc - Issue 950063002: Add patch file support to Dart embedder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/dart/embedder/dart_controller.cc

Issue 950063002: Add patch file support to Dart embedder (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/dart/embedder/dart_controller.cc

diff --git a/mojo/dart/embedder/dart_controller.cc b/mojo/dart/embedder/dart_controller.cc

index 46cdd44aa07ccc84a8cd2c8b62babb69097c1af7..0ca137ca93acf5e23b959e3e02a1cc6d3ef80400 100644

--- a/mojo/dart/embedder/dart_controller.cc

+++ b/mojo/dart/embedder/dart_controller.cc

@@ -225,11 +225,11 @@ static Dart_Handle PrepareScriptForLoading(const std::string& package_root,

const int kNumArgs = 1;

Dart_Handle dart_args[kNumArgs];

dart_args[0] = result;

- return Dart_Invoke(builtin_lib,

+ result = Dart_Invoke(builtin_lib,

Dart_NewStringFromCString("_setPackageRoot"),

kNumArgs,

dart_args);

+ DART_CHECK_VALID(result);

return result;

}