Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Side by Side Diff: mojo/dart/embedder/builtin.cc

Issue 950063002: Add patch file support to Dart embedder (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stdio.h> 5 #include <stdio.h>
6 6
7 #include "base/files/file_enumerator.h"
8 #include "base/files/file_path.h"
7 #include "base/files/file_util.h" 9 #include "base/files/file_util.h"
8 #include "base/i18n/icu_util.h" 10 #include "base/i18n/icu_util.h"
9 #include "dart/runtime/include/dart_api.h" 11 #include "dart/runtime/include/dart_api.h"
10 #include "mojo/dart/embedder/builtin.h" 12 #include "mojo/dart/embedder/builtin.h"
11 #include "mojo/dart/embedder/mojo_natives.h" 13 #include "mojo/dart/embedder/mojo_natives.h"
12 14
13 namespace mojo { 15 namespace mojo {
14 namespace dart { 16 namespace dart {
15 17
18 extern const uint8_t* snapshot_buffer;
19
20 static bool EmbedderRunningFromSnapshot() {
21 return snapshot_buffer != nullptr;
22 }
23
16 Builtin::builtin_lib_props Builtin::builtin_libraries_[] = { 24 Builtin::builtin_lib_props Builtin::builtin_libraries_[] = {
17 /* { url_, has_natives_, native_symbol_, native_resolver_ } */ 25 /* { url_, has_natives_, native_symbol_, native_resolver_,
18 {"dart:mojo_builtin", true, Builtin::NativeSymbol, Builtin::NativeLookup}, 26 patch_url_, patch_paths_ } */
19 {"dart:mojo_bindings", false, nullptr, nullptr}, 27 {"dart:mojo_builtin", true, Builtin::NativeSymbol, Builtin::NativeLookup,
20 {"dart:mojo_core", true, MojoNativeSymbol, MojoNativeLookup}, 28 nullptr, nullptr },
29 {"dart:mojo_bindings", false, nullptr, nullptr,
30 nullptr, nullptr },
31 {"dart:mojo_core", true, MojoNativeSymbol, MojoNativeLookup,
32 "dart:mojo_core-patch", mojo_core_patch_paths_ },
21 }; 33 };
22 34
23 uint8_t Builtin::snapshot_magic_number[] = {0xf5, 0xf5, 0xdc, 0xdc}; 35 uint8_t Builtin::snapshot_magic_number[] = {0xf5, 0xf5, 0xdc, 0xdc};
24 36
25 Dart_Handle Builtin::NewError(const char* format, ...) { 37 Dart_Handle Builtin::NewError(const char* format, ...) {
26 va_list args; 38 va_list args;
27 va_start(args, format); 39 va_start(args, format);
28 intptr_t len = vsnprintf(NULL, 0, format, args); 40 intptr_t len = vsnprintf(nullptr, 0, format, args);
29 va_end(args); 41 va_end(args);
30 42
31 char* buffer = reinterpret_cast<char*>(Dart_ScopeAllocate(len + 1)); 43 char* buffer = reinterpret_cast<char*>(Dart_ScopeAllocate(len + 1));
32 va_list args2; 44 va_list args2;
33 va_start(args2, format); 45 va_start(args2, format);
34 vsnprintf(buffer, (len + 1), format, args2); 46 vsnprintf(buffer, (len + 1), format, args2);
35 va_end(args2); 47 va_end(args2);
36 48
37 return Dart_NewApiError(buffer); 49 return Dart_NewApiError(buffer);
38 } 50 }
39 51
40 void Builtin::SetNativeResolver(BuiltinLibraryId id) { 52 void Builtin::SetNativeResolver(BuiltinLibraryId id) {
41 static_assert((sizeof(builtin_libraries_) / sizeof(builtin_lib_props)) == 53 static_assert((sizeof(builtin_libraries_) / sizeof(builtin_lib_props)) ==
42 kInvalidLibrary, "Unexpected number of builtin libraries"); 54 kInvalidLibrary, "Unexpected number of builtin libraries");
43 DCHECK_GE(id, kBuiltinLibrary); 55 DCHECK_GE(id, kBuiltinLibrary);
44 DCHECK_LT(id, kInvalidLibrary); 56 DCHECK_LT(id, kInvalidLibrary);
45 if (builtin_libraries_[id].has_natives_) { 57 if (builtin_libraries_[id].has_natives_) {
46 Dart_Handle url = Dart_NewStringFromCString(builtin_libraries_[id].url_); 58 Dart_Handle url = Dart_NewStringFromCString(builtin_libraries_[id].url_);
47 Dart_Handle library = Dart_LookupLibrary(url); 59 Dart_Handle library = Dart_LookupLibrary(url);
48 DCHECK(!Dart_IsError(library)); 60 DCHECK(!Dart_IsError(library));
49 // Setup the native resolver for built in library functions. 61 // Setup the native resolver for built in library functions.
50 DART_CHECK_VALID( 62 DART_CHECK_VALID(
51 Dart_SetNativeResolver(library, 63 Dart_SetNativeResolver(library,
52 builtin_libraries_[id].native_resolver_, 64 builtin_libraries_[id].native_resolver_,
53 builtin_libraries_[id].native_symbol_)); 65 builtin_libraries_[id].native_symbol_));
54 } 66 }
55 } 67 }
56 68
69 Dart_Handle Builtin::ReadStringFromFile(const char* file) {
70 base::FilePath path(base::FilePath::FromUTF8Unsafe(std::string(file)));
71 std::string source;
72 if (ReadFileToString(path, &source)) {
73 const uint8_t* text_buffer =
74 reinterpret_cast<const uint8_t*>(source.c_str());
75 const intptr_t len = source.length();
76 return Dart_NewStringFromUTF8(text_buffer, len);
77 }
78 return NewError("Could not load %s", file);
79 }
80
81 // Patch all the specified patch files in the array 'patch_files' into the
82 // library specified in 'library'.
83 void Builtin::LoadPatchFiles(Dart_Handle library,
84 const char* patch_uri,
85 const char** patch_files) {
86 for (intptr_t j = 0; patch_files[j] != NULL; j += 2) {
87 Dart_Handle patch_src = ReadStringFromFile(patch_files[j + 1]);
88 DART_CHECK_VALID(patch_src);
89 // Prepend the patch library URI to form a unique script URI for the patch.
90 intptr_t len = snprintf(NULL, 0, "%s/%s", patch_uri, patch_files[j]);
91 char* patch_filename = reinterpret_cast<char*>(malloc(len + 1));
92 snprintf(patch_filename, len + 1, "%s/%s", patch_uri, patch_files[j]);
93 Dart_Handle patch_file_uri = Dart_NewStringFromCString(patch_filename);
94 DART_CHECK_VALID(patch_file_uri);
95 free(patch_filename);
96 DART_CHECK_VALID(Dart_LibraryLoadPatch(library, patch_file_uri, patch_src));
97 }
98 }
99
57 Dart_Handle Builtin::LoadAndCheckLibrary(BuiltinLibraryId id) { 100 Dart_Handle Builtin::LoadAndCheckLibrary(BuiltinLibraryId id) {
58 static_assert((sizeof(builtin_libraries_) / sizeof(builtin_lib_props)) == 101 static_assert((sizeof(builtin_libraries_) / sizeof(builtin_lib_props)) ==
59 kInvalidLibrary, "Unexpected number of builtin libraries"); 102 kInvalidLibrary, "Unexpected number of builtin libraries");
60 DCHECK_GE(id, kBuiltinLibrary); 103 DCHECK_GE(id, kBuiltinLibrary);
61 DCHECK_LT(id, kInvalidLibrary); 104 DCHECK_LT(id, kInvalidLibrary);
62 Dart_Handle url = Dart_NewStringFromCString(builtin_libraries_[id].url_); 105 Dart_Handle url = Dart_NewStringFromCString(builtin_libraries_[id].url_);
63 Dart_Handle library = Dart_LookupLibrary(url); 106 Dart_Handle library = Dart_LookupLibrary(url);
64 DART_CHECK_VALID(library); 107 DART_CHECK_VALID(library);
108 SetNativeResolver(id);
109 if (EmbedderRunningFromSnapshot()) {
110 // Patch files are included in the snapshot.
111 return library;
112 }
113 if (builtin_libraries_[id].patch_url_ != nullptr) {
114 DCHECK(builtin_libraries_[id].patch_paths_ != nullptr);
115 LoadPatchFiles(library,
116 builtin_libraries_[id].patch_url_,
117 builtin_libraries_[id].patch_paths_);
118 }
65 return library; 119 return library;
66 } 120 }
67 121
68 } // namespace dart 122 } // namespace dart
69 } // namespace mojo 123 } // namespace mojo
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698