[Extensions] Apply WARN_UNUSED_RESULT and final keyword to ExtensionFunctions.

chrome/browser/extensions/chrome_extension_function.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_CHROME_EXTENSION_FUNCTION_H_
 #define CHROME_BROWSER_EXTENSIONS_CHROME_EXTENSION_FUNCTION_H_
 
 #include "extensions/browser/extension_function.h"
 
 class Browser;
@@ skipping 69 matching lines @@
  protected:
   ~ChromeAsyncExtensionFunction() override;
 
   // Deprecated, see AsyncExtensionFunction::RunAsync.
   virtual bool RunAsync() = 0;
 
   // ValidationFailure override to match RunAsync().
   static bool ValidationFailure(ChromeAsyncExtensionFunction* function);
 
  private:
-  ResponseAction Run() override;
+  ResponseAction Run() final;

[Devlin, 2015/02/24 17:04:42]

Even though there's about a half dozen of these, I think a basic comment like
"subclasses should implement RunAsync() instead." would be worthwhile here, so
that no one comes along and thinks it was put in errantly/flippantly.

[not at google - send to devlin, 2015/02/25 16:00:30]

"Should implement" contradicts the comment on line 72, so I've written a more
encouraging comment. Also scattered a few more comments around the place.

 };
 
 // A chrome specific analog to SyncExtensionFunction. This has access to a
 // chrome Profile.
 //
 // DEPRECATED: Please consider inherting UIThreadExtensionFunction or
 // SyncExtensionFunction directly. Then if you need access to Chrome details,
 // you can construct a ChromeExtensionFunctionDetails object within your
 // function implementation.
 class ChromeSyncExtensionFunction : public ChromeUIThreadExtensionFunction {
  public:
   ChromeSyncExtensionFunction();
 
  protected:
   ~ChromeSyncExtensionFunction() override;
 
   // Deprecated, see SyncExtensionFunction::RunSync.
   virtual bool RunSync() = 0;
 
   // ValidationFailure override to match RunSync().
   static bool ValidationFailure(ChromeSyncExtensionFunction* function);
 
  private:
-  ResponseAction Run() override;
+  ResponseAction Run() final;
 };
 
 #endif  // CHROME_BROWSER_EXTENSIONS_CHROME_EXTENSION_FUNCTION_H_