Add platform files for Background Sync API

Add platform files for Background Sync API

BUG=449443
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190757

[jkarlin, 2015-02-23 20:10:31]

jkarlin@chromium.org changed reviewers:
+ jkarlin@chromium.org

[jkarlin, 2015-02-23 20:10:32]

LGTM (with nit) but I'm not an owner.

https://codereview.chromium.org/950013002/diff/1/public/platform/modules/back...
File public/platform/modules/background_sync/WebSyncError.h (right):

https://codereview.chromium.org/950013002/diff/1/public/platform/modules/back...
public/platform/modules/background_sync/WebSyncError.h:16: ErrorTypeUnknown,
Can you add ErrorTypeNotFound for the upcoming unregister method?

[iclelland, 2015-02-23 21:17:48]

Patchset #4 (id:60001) has been deleted

[iclelland, 2015-02-23 21:18:47]

Nits picked.
ErrorTypeNotFound added to WebSyncError::ErrorType

https://codereview.chromium.org/950013002/diff/1/public/platform/modules/back...
File public/platform/modules/background_sync/WebSyncError.h (right):

https://codereview.chromium.org/950013002/diff/1/public/platform/modules/back...
public/platform/modules/background_sync/WebSyncError.h:16: ErrorTypeUnknown,
On 2015/02/23 20:10:32, jkarlin wrote:
> Can you add ErrorTypeNotFound for the upcoming unregister method?

Done.

[iclelland, 2015-02-23 21:19:19]

iclelland@chromium.org changed reviewers:
+ jochen@chromium.org

[iclelland, 2015-02-23 21:32:28]

Jochen,

jkarlin@ suggested that I should add you as a reviewer for this CL, which adds
the objects in WebKit/public/platform for the Background Sync API.

Thanks,
Ian

[jochen (gone - plz use gerrit), 2015-02-24 10:23:56]

lgtm with comment

https://codereview.chromium.org/950013002/diff/40001/public/platform/modules/...
File public/platform/modules/background_sync/WebSyncClient.h (right):

https://codereview.chromium.org/950013002/diff/40001/public/platform/modules/...
public/platform/modules/background_sync/WebSyncClient.h:24: virtual void
registerSync(WebServiceWorkerRegistration*, WebSyncRegistrationCallbacks*) {
BLINK_ASSERT_NOT_REACHED(); }
why not make them pure virtual?

https://codereview.chromium.org/950013002/diff/40001/public/platform/modules/...
File public/platform/modules/background_sync/WebSyncProvider.h (right):

https://codereview.chromium.org/950013002/diff/40001/public/platform/modules/...
public/platform/modules/background_sync/WebSyncProvider.h:26: virtual void
registerBackgroundSync(const WebSyncRegistrationOptions*,
WebSyncRegistrationCallbacks*) { BLINK_ASSERT_NOT_REACHED(); }
same here

https://codereview.chromium.org/950013002/diff/40001/public/platform/modules/...
public/platform/modules/background_sync/WebSyncProvider.h:26: virtual void
registerBackgroundSync(const WebSyncRegistrationOptions*,
WebSyncRegistrationCallbacks*) { BLINK_ASSERT_NOT_REACHED(); }
same here

[iclelland, 2015-02-24 13:23:57]

On 2015/02/24 10:23:56, jochen (slow) wrote:
> lgtm with comment
> 
>
https://codereview.chromium.org/950013002/diff/40001/public/platform/modules/...
> File public/platform/modules/background_sync/WebSyncClient.h (right):
> 
>
https://codereview.chromium.org/950013002/diff/40001/public/platform/modules/...
> public/platform/modules/background_sync/WebSyncClient.h:24: virtual void
> registerSync(WebServiceWorkerRegistration*, WebSyncRegistrationCallbacks*) {
> BLINK_ASSERT_NOT_REACHED(); }
> why not make them pure virtual?
> 
>
https://codereview.chromium.org/950013002/diff/40001/public/platform/modules/...
> File public/platform/modules/background_sync/WebSyncProvider.h (right):
> 
>
https://codereview.chromium.org/950013002/diff/40001/public/platform/modules/...
> public/platform/modules/background_sync/WebSyncProvider.h:26: virtual void
> registerBackgroundSync(const WebSyncRegistrationOptions*,
> WebSyncRegistrationCallbacks*) { BLINK_ASSERT_NOT_REACHED(); }
> same here
> 
>
https://codereview.chromium.org/950013002/diff/40001/public/platform/modules/...
> public/platform/modules/background_sync/WebSyncProvider.h:26: virtual void
> registerBackgroundSync(const WebSyncRegistrationOptions*,
> WebSyncRegistrationCallbacks*) { BLINK_ASSERT_NOT_REACHED(); }
> same here

Taking my cue from public/platform/modules/push_messaging/WebPushProvider.h and
public/platform/modules/push_messaging/WebPushClient.h, this looked like the
pattern for these objects. We're not going to leave any of them unimplemented on
the Chromium side, so I can make them pure virtual easily enough.

[iclelland, 2015-02-24 13:33:42]

https://codereview.chromium.org/950013002/diff/40001/public/platform/modules/...
File public/platform/modules/background_sync/WebSyncClient.h (right):

https://codereview.chromium.org/950013002/diff/40001/public/platform/modules/...
public/platform/modules/background_sync/WebSyncClient.h:24: virtual void
registerSync(WebServiceWorkerRegistration*, WebSyncRegistrationCallbacks*) {
BLINK_ASSERT_NOT_REACHED(); }
On 2015/02/24 10:23:55, jochen (slow) wrote:
> why not make them pure virtual?

Done.

https://codereview.chromium.org/950013002/diff/40001/public/platform/modules/...
File public/platform/modules/background_sync/WebSyncProvider.h (right):

https://codereview.chromium.org/950013002/diff/40001/public/platform/modules/...
public/platform/modules/background_sync/WebSyncProvider.h:26: virtual void
registerBackgroundSync(const WebSyncRegistrationOptions*,
WebSyncRegistrationCallbacks*) { BLINK_ASSERT_NOT_REACHED(); }
On 2015/02/24 10:23:55, jochen (slow) wrote:
> same here

Done.

[iclelland, 2015-02-24 14:45:22]

The CQ bit was checked by iclelland@chromium.org

[iclelland, 2015-02-24 14:45:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
jkarlin@chromium.org, jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/950013002/#ps80001 (title:
"Make platform methods pure virtual")

[commit-bot: I haz the power, 2015-02-24 14:45:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/950013002/80001

[commit-bot: I haz the power, 2015-02-24 16:43:03]

Committed patchset #4 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190757