Show Autofill/Wallet options only when signed in.

Show Autofill/Wallet options only when signed in.

Before this patch, you could still see the options if you signed into a whitelisted account (setting the sync experiment preference) and then signed out of the account.

BUG=none
R=brettw@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/c50285a99bc5523ea4ccdaa372a721695fb16b53

[Evan Stade, 2015-02-23 18:54:44]

estade@chromium.org changed reviewers:
+ brettw@chromium.org

[brettw, 2015-02-23 19:09:47]

lgtm

[Evan Stade, 2015-02-26 00:15:42]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2015-02-26 00:15:42]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/950003002/#ps40001 (title:
"pdm")

[commit-bot: I haz the power, 2015-02-26 00:16:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/950003002/40001

[commit-bot: I haz the power, 2015-02-26 02:38:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-26 02:38:59]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Evan Stade, 2015-02-26 18:44:53]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2015-02-26 18:46:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/950003002/40001

[commit-bot: I haz the power, 2015-02-26 20:27:21]

Patchset 3 (id:??) landed as
https://crrev.com/c50285a99bc5523ea4ccdaa372a721695fb16b53
Cr-Commit-Position: refs/heads/master@{#318298}

[Evan Stade, 2015-02-26 20:27:46]

Committed patchset #3 (id:40001) manually as
c50285a99bc5523ea4ccdaa372a721695fb16b53 (presubmit successful).

[stevenjb, 2015-02-26 23:17:53]

On 2015/02/26 20:27:46, Evan Stade wrote:
> Committed patchset #3 (id:40001) manually as
> c50285a99bc5523ea4ccdaa372a721695fb16b53 (presubmit successful).

The chromeos failures are failing on the tree:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2...
http://master.chrome.corp.google.com:8011/builders/cros%20trunk/builds/30717

I am going to try to confirm that this CL caused them before reverting this.

[stevenjb, 2015-02-26 23:26:10]

stevenjb@chromium.org changed reviewers:
+ stevenjb@chromium.org

[stevenjb, 2015-02-26 23:26:11]

Confirmed this is the cause. Reverting.

https://codereview.chromium.org/950003002/diff/40001/chrome/browser/ui/webui/...
File chrome/browser/ui/webui/options/autofill_options_handler.cc (right):

https://codereview.chromium.org/950003002/diff/40001/chrome/browser/ui/webui/...
chrome/browser/ui/webui/options/autofill_options_handler.cc:350:
personal_data_->IsExperimentalWalletIntegrationEnabled());
It looks like personal_data_ is tested elsewhere in this code, it may not be
available always on ChromeOS? Either that or |service| is null in the browser
tests.

[stevenjb, 2015-02-26 23:28:15]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/959053003/ by stevenjb@chromium.org.

The reason for reverting is: Crash in browser tests on Chrome OS

crbug.com/462408
.

[jam, 2015-02-26 23:42:55]

this kept correctly failing on the trybots,and then it was checked in manually.
why?

[Evan Stade, 2015-02-26 23:59:49]

On 2015/02/26 23:42:55, jam wrote:
> this kept correctly failing on the trybots,and then it was checked in
manually.
> why?

oops, I incorrectly read the test results as the same (with patch) and (without
patch)

[jam, 2015-02-27 00:32:58]

On 2015/02/26 23:59:49, Evan Stade wrote:
> On 2015/02/26 23:42:55, jam wrote:
> > this kept correctly failing on the trybots,and then it was checked in
> manually.
> > why?
> 
> oops, I incorrectly read the test results as the same (with patch) and
(without
> patch)

please avoid manually committing in the future then. the commit queue is faster
and safer.