Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 949953004: Temporarily disable stack trace tests, pending investigation on XP bots (Closed)

Created:
5 years, 10 months ago by scottmg
Modified:
5 years, 10 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Temporarily disable stack trace tests, pending investigation on XP bots R=rmsousa@chromium.org TBR=beaudoin, binjin, kaliamoorthi, noms, rmsousa BUG=461160 Committed: https://chromium.googlesource.com/chromium/src/+/941e4f2044c6ccce85b2efc6b5c254978ff9d754

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M base/debug/debugger_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M base/debug/stack_trace_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M base/process/process_util_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
scottmg
5 years, 10 months ago (2015-02-24 01:43:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/949953004/1
5 years, 10 months ago (2015-02-24 01:44:38 UTC) #3
rmsousa
lgtm
5 years, 10 months ago (2015-02-24 01:48:40 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/26949)
5 years, 10 months ago (2015-02-24 01:50:51 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/941e4f2044c6ccce85b2efc6b5c254978ff9d754 Cr-Commit-Position: refs/heads/master@{#317732}
5 years, 10 months ago (2015-02-24 01:53:37 UTC) #7
scottmg
5 years, 10 months ago (2015-02-24 01:53:52 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
941e4f2044c6ccce85b2efc6b5c254978ff9d754 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698