Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(940)

Issue 949943003: In preparation for adding appcontainer token to renderer, these are content side changes. (Closed)

Created:
5 years, 10 months ago by Shrikant Kelkar
Modified:
5 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

In preparation for adding appcontainer token to renderer, these are content side changes. In this CL, we add appcontainer related attributes in PreSpawnTarget for renderer. Though we modify policy here, it is still not being honored, that will happen in next CL. BUG=455496 R=cpu, jschuh, rvargas Committed: https://crrev.com/7e41fb89274cd1f3e71d3bd6e5b75e211b8fa103 Cr-Commit-Position: refs/heads/master@{#319208}

Patch Set 1 #

Patch Set 2 : Removed sid.* files and modified code to call installappcontainer. #

Patch Set 3 : Removed unused include sid.h #

Patch Set 4 : Contained changes to one file. #

Patch Set 5 : Removed unwanted include. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 3 2 chunks +16 lines, -0 lines 2 comments Download

Messages

Total messages: 15 (4 generated)
Shrikant Kelkar
ptal.
5 years, 10 months ago (2015-02-23 21:43:19 UTC) #1
Shrikant Kelkar
+rvargas separated content related code. ptal.
5 years, 10 months ago (2015-02-24 20:37:05 UTC) #3
Shrikant Kelkar
ptal. After discussion with rvargas@ removed sid changes and for now added static appcontainer sid.
5 years, 10 months ago (2015-02-25 00:15:34 UTC) #4
Shrikant Kelkar
ptal. These are content side changes after landing sandbox side changes.
5 years, 9 months ago (2015-03-02 21:25:15 UTC) #5
cpu_(ooo_6.6-7.5)
lgtm https://codereview.chromium.org/949943003/diff/80001/content/browser/renderer_host/render_process_host_impl.cc File content/browser/renderer_host/render_process_host_impl.cc (right): https://codereview.chromium.org/949943003/diff/80001/content/browser/renderer_host/render_process_host_impl.cc#newcode341 content/browser/renderer_host/render_process_host_impl.cc:341: at least lets have two sids, one for ...
5 years, 9 months ago (2015-03-02 22:31:33 UTC) #6
Shrikant Kelkar
https://codereview.chromium.org/949943003/diff/80001/content/browser/renderer_host/render_process_host_impl.cc File content/browser/renderer_host/render_process_host_impl.cc (right): https://codereview.chromium.org/949943003/diff/80001/content/browser/renderer_host/render_process_host_impl.cc#newcode341 content/browser/renderer_host/render_process_host_impl.cc:341: On 2015/03/02 22:31:32, cpu wrote: > at least lets ...
5 years, 9 months ago (2015-03-02 23:03:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/949943003/80001
5 years, 9 months ago (2015-03-02 23:04:21 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel/builds/59988)
5 years, 9 months ago (2015-03-03 03:43:09 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/949943003/80001
5 years, 9 months ago (2015-03-05 02:14:51 UTC) #13
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 9 months ago (2015-03-05 03:49:51 UTC) #14
commit-bot: I haz the power
5 years, 9 months ago (2015-03-05 03:50:38 UTC) #15
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/7e41fb89274cd1f3e71d3bd6e5b75e211b8fa103
Cr-Commit-Position: refs/heads/master@{#319208}

Powered by Google App Engine
This is Rietveld 408576698