Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 949933003: Use traits instead of table for color glyph detection. (Closed)

Created:
5 years, 10 months ago by bungeman-skia
Modified:
5 years, 10 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Use traits instead of table for color glyph detection. The CTFont already knows if a font might contain color glyphs, so use that information directly instead of guessing ourselves. Committed: https://skia.googlesource.com/skia/+/98c251bc7eec5aa236700d9936c740f2744788db

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -15 lines) Patch
M src/ports/SkFontHost_mac.cpp View 3 chunks +3 lines, -15 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
bungeman-skia
5 years, 10 months ago (2015-02-23 22:03:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/949933003/1
5 years, 10 months ago (2015-02-23 22:04:28 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 10 months ago (2015-02-23 22:04:29 UTC) #5
mtklein
lgtm
5 years, 10 months ago (2015-02-23 22:23:17 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/98c251bc7eec5aa236700d9936c740f2744788db
5 years, 10 months ago (2015-02-23 22:24:09 UTC) #7
bungeman-skia
5 years, 10 months ago (2015-02-24 16:46:53 UTC) #8
Message was sent while issue was closed.
On 2015/02/23 22:24:09, I haz the power (commit-bot) wrote:
> Committed patchset #1 (id:1) as
> https://skia.googlesource.com/skia/+/98c251bc7eec5aa236700d9936c740f2744788db

Followed up with https://codereview.chromium.org/951723003/ .

Powered by Google App Engine
This is Rietveld 408576698