Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(951)

Issue 949933002: ES6 collections: Fix order of constructor logic (Closed)

Created:
5 years, 10 months ago by arv (Not doing code reviews)
Modified:
5 years, 10 months ago
Reviewers:
adamk
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

ES6 collections: Fix order of constructor logic The adder should be gotten before the iterator. Motivation: Once this is done we should be able to use a for-of loop instead which leads to cleaner code and correct behavior once the for-of loop correctly supports abrupt completion. BUG=None LOG=N R=adamk Committed: https://crrev.com/36e72aedf073a78915c5412e77499dbe98878766 Cr-Commit-Position: refs/heads/master@{#26803}

Patch Set 1 #

Patch Set 2 : cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -4 lines) Patch
M src/collection.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/weak-collection.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/es6/collections.js View 1 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
arv (Not doing code reviews)
cleanup
5 years, 10 months ago (2015-02-23 17:07:22 UTC) #1
arv (Not doing code reviews)
PTAL
5 years, 10 months ago (2015-02-23 17:07:54 UTC) #2
adamk
lgtm
5 years, 10 months ago (2015-02-23 18:17:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/949933002/20001
5 years, 10 months ago (2015-02-23 18:54:40 UTC) #5
commit-bot: I haz the power
Failed to apply the patch.
5 years, 10 months ago (2015-02-23 18:55:39 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-23 18:55:41 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 18:55:54 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/36e72aedf073a78915c5412e77499dbe98878766
Cr-Commit-Position: refs/heads/master@{#26803}

Powered by Google App Engine
This is Rietveld 408576698