Issue 94993004: Move heap profiler state flags to HeapProfiler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 94993004: Move heap profiler state flags to HeapProfiler (Closed)

Created:
7 years ago by yurys

Modified:
7 years ago

Reviewers:
alph, Michael Starzinger, loislo

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Move heap profiler state flags to HeapProfiler - moved is_tracking_objects_ flag to HeapProfiler and renamed it to is_tracking_objects_moves_ - Removed redundant call to UpdateHeapObjectsMap BUG=None LOG=N R=loislo@chromium.org, mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18149

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -26 lines)			Patch
M	src/builtins.cc	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	src/heap.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/heap-profiler.h	View	2 chunks	+3 lines, -7 lines	0 comments	Download
M	src/heap-profiler.cc	View	4 chunks	+4 lines, -2 lines	0 comments	Download
M	src/heap-snapshot-generator.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	src/heap-snapshot-generator.cc	View	3 chunks	+1 line, -4 lines	0 comments	Download
M	src/mark-compact.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

yurys

This is a refactoring which I don't want to interleave with other allocation tracker changes.

7 years ago (2013-11-28 14:53:22 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r18149 (presubmit successful).