Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: platform_tools/android/gyp_gen/tool_makefile_writer.py

Issue 949853003: Ensure that skia's test resources are properly packaged on Android (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | platform_tools/android/tests/expectations/tool/Android.mk » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: platform_tools/android/gyp_gen/tool_makefile_writer.py
diff --git a/platform_tools/android/gyp_gen/tool_makefile_writer.py b/platform_tools/android/gyp_gen/tool_makefile_writer.py
index 897a2b86078e02b0e55dfdb4ae7829a36f0051c3..ac00be8e1c4b648eab58225e037b828643017766 100644
--- a/platform_tools/android/gyp_gen/tool_makefile_writer.py
+++ b/platform_tools/android/gyp_gen/tool_makefile_writer.py
@@ -14,6 +14,18 @@ import makefile_writer
import os
import vars_dict_lib
+SKIA_RESOURCES = (
+"""
+# Setup directory to store skia's resources in the directory structure that
+# the Android testing infrastructure expects
+skia_res_dir := $(call intermediates-dir-for,PACKAGING,skia_resources)/DATA
+$(shell mkdir -p $(skia_res_dir))
+$(shell cp -r $(LOCAL_PATH)/../resources/. $(skia_res_dir)/skia_resources)
+LOCAL_PICKUP_FILES := $(skia_res_dir)
+skia_res_dir :=
+
+"""
+)
def write_tool_android_mk(target_dir, var_dict):
"""Write Android.mk for a Skia tool.
@@ -31,9 +43,7 @@ def write_tool_android_mk(target_dir, var_dict):
makefile_writer.write_local_vars(f, var_dict, False, None)
- makefile_writer.write_group(f, 'LOCAL_PICKUP_FILES',
- ['$(LOCAL_PATH)/../resources'], False)
-
+ f.write(SKIA_RESOURCES)
f.write('include $(BUILD_NATIVE_TEST)\n')
« no previous file with comments | « no previous file | platform_tools/android/tests/expectations/tool/Android.mk » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698