Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 949823002: Fix crash on app list start page contents not existing. (Closed)

Created:
5 years, 10 months ago by calamity
Modified:
5 years, 10 months ago
Reviewers:
Matt Giuca
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix crash on app list start page contents not existing. This CL adds a null check around an access to the app list web contents. BUG=460388 Committed: https://crrev.com/386f2bcf06d5fb74c176de864190a1c555ad618f Cr-Commit-Position: refs/heads/master@{#317546}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M chrome/browser/ui/app_list/start_page_service.cc View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
calamity
5 years, 10 months ago (2015-02-23 04:39:31 UTC) #3
Matt Giuca
lgtm
5 years, 10 months ago (2015-02-23 04:40:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/949823002/20001
5 years, 10 months ago (2015-02-23 05:29:33 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 10 months ago (2015-02-23 05:43:23 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 05:44:00 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/386f2bcf06d5fb74c176de864190a1c555ad618f
Cr-Commit-Position: refs/heads/master@{#317546}

Powered by Google App Engine
This is Rietveld 408576698