download_sdk_extras: Catch the correct error.

build/download_sdk_extras.py

Index: build/download_sdk_extras.py
diff --git a/build/download_sdk_extras.py b/build/download_sdk_extras.py
index d22d8850c2e762919fb70d1fd7002f2cdebc8c35..d7c5d6cad6c9eec10690644bf7ba485189e3f287 100755
--- a/build/download_sdk_extras.py
+++ b/build/download_sdk_extras.py
@@ -59,9 +59,9 @@ def main():
       try:
         subprocess.check_call(['python', GSUTIL_PATH, '--force-version', '4.7',
                                'cp', package_zip, local_zip])
-      except AccessDeniedException:
-        print ('WARNING: Bot does not have permission to download SDK packages.'
-               ' If this bot compiles for Android, it may have errors.')
+      except subprocess.CalledProcessError:
+        print ('WARNING: Failed to download SDK packages. If this bot compiles '

[navabi, 2015/02/23 17:40:49]

We still need to catch the AccessDeniedExceptions for cases where the call works
but the bot does not have gstuil credentials.

[dnj, 2015/02/23 17:43:17]

We can't catch AccessDeniedException. gsutil, which emits the exception, is
executing in a subprocess, so the only feedback that this script gets is the
subprocess return code, not the actual exception.

This construction catches that and prints the warning. It (something) looks
like:

AccessDeniedException: 403 << output from gsutil, causing it to return non-zero.
WARNING: Failed to download SDK packages... << output from this 'print'.

[scottmg, 2015/02/23 18:19:44]

Is is useful to print the content of the exception here? (e.g. for the command
line)

+               'for Android, it may have errors.')
         return 0
     # Always clean dir and extract zip to ensure correct contents.
     clean_and_extract(package['dir_name'], package['package'], package['zip'])