Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 949783003: Add WiMAX to ONC validation list (Closed)

Created:
5 years, 10 months ago by stevenjb
Modified:
5 years, 10 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, hashimoto+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add WiMAX to ONC validation list Currently type WiMAX fails ONC validation so any property changes from Settings are ignored. This also fixes the Cellular translation and adds both Cellular and WiMAX to the validation tests. BUG=460829 Committed: https://crrev.com/b1754c5c8b5b939aac67e1e43b71a70c50e64bac Cr-Commit-Position: refs/heads/master@{#318162}

Patch Set 1 #

Patch Set 2 : Add and fix tests #

Total comments: 3

Patch Set 3 : Remove fake WiMAX EAP property #

Patch Set 4 : Fix browser_tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -27 lines) Patch
M chrome/test/data/extensions/api_test/networking_private/chromeos/test.js View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/dbus/fake_shill_manager_client.cc View 1 2 1 chunk +7 lines, -13 lines 0 comments Download
M chromeos/network/onc/onc_translation_tables.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chromeos/network/onc/onc_translator_shill_to_onc.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chromeos/network/onc/onc_validator.cc View 2 chunks +8 lines, -3 lines 0 comments Download
M chromeos/network/onc/onc_validator_unittest.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chromeos/test/data/network/shill_wimax_with_state.json View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chromeos/test/data/network/translation_of_shill_cellular_with_state.onc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/test/data/network/translation_of_shill_wimax_with_state.onc View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
stevenjb
https://codereview.chromium.org/949783003/diff/20001/chromeos/test/data/network/shill_wimax_with_state.json File chromeos/test/data/network/shill_wimax_with_state.json (left): https://codereview.chromium.org/949783003/diff/20001/chromeos/test/data/network/shill_wimax_with_state.json#oldcode5 chromeos/test/data/network/shill_wimax_with_state.json:5: "EAP.Identity": "${LOGIN_ID}@my.domain.com", We expect 'Outer' in the ONC file ...
5 years, 10 months ago (2015-02-25 01:44:44 UTC) #2
pneubeck (no reviews)
lgtm https://codereview.chromium.org/949783003/diff/20001/chromeos/dbus/fake_shill_manager_client.cc File chromeos/dbus/fake_shill_manager_client.cc (right): https://codereview.chromium.org/949783003/diff/20001/chromeos/dbus/fake_shill_manager_client.cc#newcode746 chromeos/dbus/fake_shill_manager_client.cc:746: profiles->AddService(shared_profile, kWimaxPath); probably not an expected combination: wimax+eap+sharedprofile
5 years, 10 months ago (2015-02-25 08:47:20 UTC) #3
stevenjb
https://codereview.chromium.org/949783003/diff/20001/chromeos/dbus/fake_shill_manager_client.cc File chromeos/dbus/fake_shill_manager_client.cc (right): https://codereview.chromium.org/949783003/diff/20001/chromeos/dbus/fake_shill_manager_client.cc#newcode746 chromeos/dbus/fake_shill_manager_client.cc:746: profiles->AddService(shared_profile, kWimaxPath); On 2015/02/25 08:47:19, pneubeck wrote: > probably ...
5 years, 10 months ago (2015-02-25 18:19:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/949783003/40001
5 years, 10 months ago (2015-02-25 18:52:00 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/29341)
5 years, 10 months ago (2015-02-25 22:45:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/949783003/60001
5 years, 10 months ago (2015-02-25 23:46:30 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-26 00:46:56 UTC) #13
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 00:47:45 UTC) #14
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/b1754c5c8b5b939aac67e1e43b71a70c50e64bac
Cr-Commit-Position: refs/heads/master@{#318162}

Powered by Google App Engine
This is Rietveld 408576698