Issue 949763005: Terminate <object> to fix flaky test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 949763005: Terminate <object> to fix flaky test. (Closed)

Created:
5 years, 10 months ago by rune

Modified:
5 years, 10 months ago

Reviewers:
tkent

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Terminate <object> to fix flaky test. The question is if the test would still catch the crash, but the initial commit just says the test is for a crash that is no longer reproducible, so it is hard to tell. An alternative is to just remove the test. R=tkent@chromium.org BUG=328234 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190882

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -16 lines)			Patch
M	LayoutTests/FlakyTests	View	1 chunk	+0 lines, -12 lines	0 comments	Download
M	LayoutTests/TestExpectations	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	LayoutTests/fast/css/mask-missing-image-crash.html	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

tkent

http://trac.webkit.org/changeset/39166 Wow, test-only CL and rdar: bug URL. I support to remove the test. anyway, ...

5 years, 10 months ago (2015-02-25 23:59:20 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/949763005/1

5 years, 10 months ago (2015-02-26 07:59:52 UTC) #4

commit-bot: I haz the power

5 years, 10 months ago (2015-02-26 09:12:50 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190882

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages