Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 949753006: Disable the autofill/wallet settings in chrome://settings/autofill (Closed)

Created:
5 years, 10 months ago by Evan Stade
Modified:
5 years, 10 months ago
Reviewers:
brettw
CC:
chromium-reviews, dbeam+watch-options_chromium.org, estade+watch_chromium.org, michaelpg+watch-options_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable the autofill/wallet settings in chrome://settings/autofill Will merge this to M42, then revert on trunk. BUG=460900 Committed: https://crrev.com/0d59aeae3e815c53b10fb0ffc1199be524c62f86 Cr-Commit-Position: refs/heads/master@{#317638}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/ui/webui/options/autofill_options_handler.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Evan Stade
the correct fix is here: https://codereview.chromium.org/950003002/ I'm slightly worried that some users will be whitelisted ...
5 years, 10 months ago (2015-02-23 19:01:44 UTC) #2
brettw
lgtm
5 years, 10 months ago (2015-02-23 19:05:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/949753006/1
5 years, 10 months ago (2015-02-23 19:21:13 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-23 20:20:29 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 20:21:14 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0d59aeae3e815c53b10fb0ffc1199be524c62f86
Cr-Commit-Position: refs/heads/master@{#317638}

Powered by Google App Engine
This is Rietveld 408576698