Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 949653003: When page translation state is updated, just ask the toolbar to update, don't (Closed)

Created:
5 years, 10 months ago by Peter Kasting
Modified:
5 years, 10 months ago
Reviewers:
hajimehoshi
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

When page translation state is updated, just ask the toolbar to update, don't also ask it to restore saved state. This eliminates the BrowserContentTranslateDriverObserver class in favor of just implementing this on Browser directly as various other such observer implementations do -- allowing the code to call the UpdateToolbar() method instead of BrowserWindow::UpdateToolbar(), whose correct use is slightly less clear. BUG=459445 TEST=See steps on bug comment 22. In step 1, be sure to restart Chrome after changing the language, and then set Chrome to prompt to translate pages in English. Committed: https://crrev.com/cc29d20ef40d7b3d54e7ffbe9ba035d1a0c71ae1 Cr-Commit-Position: refs/heads/master@{#317993}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -84 lines) Patch
M chrome/browser/ui/browser.h View 5 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/ui/browser.cc View 5 chunks +23 lines, -7 lines 0 comments Download
D chrome/browser/ui/browser_content_translate_driver_observer.h View 1 chunk +0 lines, -35 lines 0 comments Download
D chrome/browser/ui/browser_content_translate_driver_observer.cc View 1 chunk +0 lines, -37 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Peter Kasting
5 years, 10 months ago (2015-02-24 02:25:21 UTC) #2
hajimehoshi
lgtm, thanks
5 years, 10 months ago (2015-02-24 05:07:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/949653003/1
5 years, 10 months ago (2015-02-25 06:01:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-25 06:06:03 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 06:07:08 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cc29d20ef40d7b3d54e7ffbe9ba035d1a0c71ae1
Cr-Commit-Position: refs/heads/master@{#317993}

Powered by Google App Engine
This is Rietveld 408576698