net/socket/ssl_client_socket_unittest.cc - Issue 949633002: Include both certificate chains in invalid cert reporting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/ssl_client_socket_unittest.cc

Issue 949633002: Include both certificate chains in invalid cert reporting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add a comment to cert logger pb Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/socket/ssl_client_socket_unittest.cc

diff --git a/net/socket/ssl_client_socket_unittest.cc b/net/socket/ssl_client_socket_unittest.cc

index 287dbb85ae36245a1d30fda5d2e7cd26d00e317d..dfd00eaa5ecd4323835e9b2ebf590080c850c671 100644

--- a/net/socket/ssl_client_socket_unittest.cc

+++ b/net/socket/ssl_client_socket_unittest.cc

@@ -2414,8 +2414,10 @@ TEST_F(SSLClientSocketTest, VerifyServerChainProperlyOrdered) {

X509Certificate::FORMAT_AUTO);

// Get the server certificate as received client side.

+ SSLInfo ssl_info;

+ sock->GetSSLInfo(&ssl_info);

scoped_refptr<X509Certificate> server_certificate =

- sock->GetUnverifiedServerCertificateChain();

+ ssl_info.unverified_server_cert;

// Get the intermediates as received client side.

const X509Certificate::OSCertHandles& server_intermediates =

« net/cert/cert_verify_result.h ('K') | « net/socket/ssl_client_socket_openssl.cc ('k') | net/ssl/ssl_info.h » ('j') | net/ssl/ssl_info.h » ('J')