Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: net/socket/ssl_client_socket_nss.cc

Issue 949633002: Include both certificate chains in invalid cert reporting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add a comment to cert logger pb Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/socket/ssl_client_socket_nss.cc
diff --git a/net/socket/ssl_client_socket_nss.cc b/net/socket/ssl_client_socket_nss.cc
index 011474fedca1a1ea5efd9c9270aa75566d58071c..35c39fcd9a5bac9b84ea3ada4087cbce469bfe54 100644
--- a/net/socket/ssl_client_socket_nss.cc
+++ b/net/socket/ssl_client_socket_nss.cc
@@ -2895,6 +2895,8 @@ bool SSLClientSocketNSS::GetSSLInfo(SSLInfo* ssl_info) {
ssl_info->cert_status = server_cert_verify_result_.cert_status;
ssl_info->cert = server_cert_verify_result_.verified_cert;
+ ssl_info->unverified_server_cert =
+ server_cert_verify_result_.unverified_server_cert;
AddSCTInfoToSSLInfo(ssl_info);
@@ -3468,6 +3470,8 @@ int SSLClientSocketNSS::DoVerifyCert(int result) {
server_cert_verify_result_.Reset();
server_cert_verify_result_.cert_status = cert_status;
server_cert_verify_result_.verified_cert = core_->state().server_cert;
+ server_cert_verify_result_.unverified_server_cert =
+ core_->state().server_cert;
return OK;
}
@@ -3632,11 +3636,6 @@ void SSLClientSocketNSS::AddSCTInfoToSSLInfo(SSLInfo* ssl_info) const {
}
}
-scoped_refptr<X509Certificate>
-SSLClientSocketNSS::GetUnverifiedServerCertificateChain() const {
- return core_->state().server_cert.get();
-}
-
ChannelIDService* SSLClientSocketNSS::GetChannelIDService() const {
return channel_id_service_;
}

Powered by Google App Engine
This is Rietveld 408576698