chrome/browser/extensions/api/socket/tls_socket_unittest.cc - Issue 949633002: Include both certificate chains in invalid cert reporting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/socket/tls_socket_unittest.cc

Issue 949633002: Include both certificate chains in invalid cert reporting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add a comment to cert logger pb Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/socket/tls_socket_unittest.cc

diff --git a/chrome/browser/extensions/api/socket/tls_socket_unittest.cc b/chrome/browser/extensions/api/socket/tls_socket_unittest.cc

index a427bd0e898d78d35967563b6fae356f2fdb303e..e4e09cb3d088f6a071621f57fd37957d42dc0a55 100644

--- a/chrome/browser/extensions/api/socket/tls_socket_unittest.cc

+++ b/chrome/browser/extensions/api/socket/tls_socket_unittest.cc

@@ -66,8 +66,6 @@ class MockSSLClientSocket : public net::SSLClientSocket {

MOCK_METHOD1(GetSSLCertRequestInfo, void(net::SSLCertRequestInfo*));

MOCK_METHOD1(GetNextProto,

net::SSLClientSocket::NextProtoStatus(std::string*));

- MOCK_CONST_METHOD0(GetUnverifiedServerCertificateChain,

- scoped_refptr<net::X509Certificate>());

MOCK_CONST_METHOD0(GetChannelIDService, net::ChannelIDService*());

virtual bool IsConnected() const override { return true; }

« no previous file with comments | « no previous file | chrome/browser/net/cert_logger.proto » ('j') | chrome/browser/net/chrome_fraudulent_certificate_reporter.cc » ('J')