chrome/browser/net/chrome_fraudulent_certificate_reporter.h - Issue 949633002: Include both certificate chains in invalid cert reporting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/net/chrome_fraudulent_certificate_reporter.h

Issue 949633002: Include both certificate chains in invalid cert reporting (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/net/cert_logger.proto ('k') | chrome/browser/net/chrome_fraudulent_certificate_reporter.cc » ('j') | chrome/browser/net/chrome_fraudulent_certificate_reporter_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/net/chrome_fraudulent_certificate_reporter.h

diff --git a/chrome/browser/net/chrome_fraudulent_certificate_reporter.h b/chrome/browser/net/chrome_fraudulent_certificate_reporter.h

index 987a485bceb5e4704e5c00bfb76adb84a77f0cd2..4b4ebdb0b7857e7401696292bb77fa22721cb04a 100644

--- a/chrome/browser/net/chrome_fraudulent_certificate_reporter.h

+++ b/chrome/browser/net/chrome_fraudulent_certificate_reporter.h

@@ -46,6 +46,11 @@ class ChromeFraudulentCertificateReporter

const GURL pinning_violation_upload_url_;

const GURL invalid_chain_upload_url_;

+ static std::string BuildReport(

estark 2015/02/21 06:42:23 (I just made this a static method on the class so

+ ChromeFraudulentCertificateReporter::ReportType type,

+ const std::string& hostname,

+ const net::SSLInfo& ssl_info);

private:

// Performs post-report cleanup.

void RequestComplete(net::URLRequest* request);