cc/test/layer_tree_pixel_test.cc - Issue 94963003: Take GL version and extensions correctly into account when binding functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/test/layer_tree_pixel_test.cc

Issue 94963003: Take GL version and extensions correctly into account when binding functions (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Addressed review feedback and Mac build failure Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/test/layer_tree_pixel_test.cc

diff --git a/cc/test/layer_tree_pixel_test.cc b/cc/test/layer_tree_pixel_test.cc

index 3ad33dc5937ada330ca72632f629c18d8205d49a..36b3be62a45e831822986d62714fca524844b911 100644

--- a/cc/test/layer_tree_pixel_test.cc

+++ b/cc/test/layer_tree_pixel_test.cc

@@ -53,7 +53,7 @@ scoped_ptr<OutputSurface> LayerTreePixelTest::CreateOutputSurface(

case GL_WITH_DEFAULT:

case GL_WITH_BITMAP: {

- CHECK(gfx::InitializeGLBindings(gfx::kGLImplementationOSMesaGL));

+ CHECK(gfx::InitializeStaticGLBindings(gfx::kGLImplementationOSMesaGL));

using webkit::gpu::ContextProviderInProcess;

output_surface = make_scoped_ptr(new PixelTestOutputSurface(

@@ -311,7 +311,7 @@ void LayerTreePixelTest::CopyBitmapToTextureMailboxAsTexture(

DCHECK_GT(bitmap.width(), 0);

DCHECK_GT(bitmap.height(), 0);

- CHECK(gfx::InitializeGLBindings(gfx::kGLImplementationOSMesaGL));

+ CHECK(gfx::InitializeStaticGLBindings(gfx::kGLImplementationOSMesaGL));

using webkit::gpu::WebGraphicsContext3DInProcessCommandBufferImpl;

scoped_ptr<blink::WebGraphicsContext3D> context3d(

« no previous file with comments | « no previous file | cc/test/pixel_test.cc » ('j') | ui/gl/generate_bindings.py » ('J')