Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Issue 949623007: Revert of Revert of Carry out a resize even if no layout has been performed. (Closed)

Created:
5 years, 10 months ago by gsennton
Modified:
5 years, 10 months ago
CC:
blink-reviews, Ken Russell (switch to Gerrit)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Revert of Carry out a resize even if no layout has been performed. (patchset #1 id:1 of https://codereview.chromium.org/945853005/) Reason for revert: Reland as this was not causing the problem. Original issue's description: > Revert of Carry out a resize even if no layout has been performed. (patchset #11 id:200001 of https://codereview.chromium.org/911083002/) > > Reason for revert: > Speculative revert for: https://code.google.com/p/chromium/issues/detail?id=460294 > > Original issue's description: > > Carry out a resize even if no layout has been performed. > > > > Add a FrameView resize in WebviewImpl::performResize if no layout has been > > performed. This to fix the case where a layout is not performed because the > > layout height is forced to zero (and therefore no layouts are performed when > > the actual height is changed). > > > > BUG=457159 > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190424 > > TBR=aelias@chromium.org,boliu@chromium.org,hush@chromium.org,gsennton@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=457159 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190607 TBR=aelias@chromium.org,boliu@chromium.org,hush@chromium.org,kbr@chromium.org,marcheu@chromium.org BUG=457159 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190758

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -27 lines) Patch
M Source/web/WebViewImpl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 3 chunks +37 lines, -26 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 2 chunks +44 lines, -1 line 0 comments Download
A Source/web/tests/data/button.html View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
gsennton
Created Revert of Revert of Carry out a resize even if no layout has been ...
5 years, 10 months ago (2015-02-24 15:24:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/949623007/1
5 years, 10 months ago (2015-02-24 15:26:20 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 10 months ago (2015-02-24 15:26:23 UTC) #5
Torne
lgtm
5 years, 10 months ago (2015-02-24 15:28:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/949623007/1
5 years, 10 months ago (2015-02-24 15:29:20 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 16:46:25 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190758

Powered by Google App Engine
This is Rietveld 408576698