Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1176)

Unified Diff: test/cctest/test-heap.cc

Issue 949623006: Attach snapshot data blob to the isolate. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/snapshot-external.cc ('k') | test/cctest/test-serialize.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-heap.cc
diff --git a/test/cctest/test-heap.cc b/test/cctest/test-heap.cc
index 719a6c76b73cefe306cbbd2f93681443ccedf9c7..b5e091fc42d95e4ee8cc5ef4d8dc6c293cceb1da 100644
--- a/test/cctest/test-heap.cc
+++ b/test/cctest/test-heap.cc
@@ -5073,10 +5073,10 @@ TEST(Regress442710) {
TEST(NumberStringCacheSize) {
- if (!Snapshot::HaveASnapshotToStartFrom()) return;
// Test that the number-string cache has not been resized in the snapshot.
CcTest::InitializeVM();
Isolate* isolate = CcTest::i_isolate();
+ if (!isolate->snapshot_available()) return;
Heap* heap = isolate->heap();
CHECK_EQ(TestHeap::kInitialNumberStringCacheSize * 2,
heap->number_string_cache()->length());
@@ -5093,25 +5093,3 @@ TEST(PathTracer) {
CcTest::i_isolate()->heap()->TracePathToObject(*o);
}
#endif // DEBUG
-
-
-TEST(FirstPageFitsStartup) {
- // Test that the first page sizes provided by the default snapshot are large
- // enough to fit everything right after startup and creating one context.
- // If this test fails, we are allocating too much aside from deserialization.
- if (!Snapshot::HaveASnapshotToStartFrom()) return;
- if (Snapshot::EmbedsScript()) return;
- CcTest::InitializeVM();
- LocalContext env;
- PagedSpaces spaces(CcTest::heap());
- for (PagedSpace* s = spaces.next(); s != NULL; s = spaces.next()) {
- uint32_t default_size = s->AreaSize();
- uint32_t reduced_size = Snapshot::SizeOfFirstPage(s->identity());
- if (reduced_size == default_size) continue;
- int counter = 0;
- Page* page = NULL;
- for (PageIterator it(s); it.has_next(); page = it.next()) counter++;
- CHECK_LE(counter, 1);
- CHECK(static_cast<uint32_t>(page->area_size()) == reduced_size);
- }
-}
« no previous file with comments | « src/snapshot-external.cc ('k') | test/cctest/test-serialize.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698