Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: test/cctest/test-heap.cc

Issue 949623006: Attach snapshot data blob to the isolate. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/test-heap.cc
diff --git a/test/cctest/test-heap.cc b/test/cctest/test-heap.cc
index ae3c1d365c4a3368d0f3ebdfafba323f342c7171..c2ee746a43d10065e025b7fc780faa7f634c6b5a 100644
--- a/test/cctest/test-heap.cc
+++ b/test/cctest/test-heap.cc
@@ -5073,7 +5073,7 @@ TEST(Regress442710) {
TEST(NumberStringCacheSize) {
- if (!Snapshot::HaveASnapshotToStartFrom()) return;
+ if (!Snapshot::HaveASnapshotToStartFrom(CcTest::i_isolate())) return;
// Test that the number-string cache has not been resized in the snapshot.
CcTest::InitializeVM();
Isolate* isolate = CcTest::i_isolate();
@@ -5099,14 +5099,15 @@ TEST(FirstPageFitsStartup) {
// Test that the first page sizes provided by the default snapshot are large
// enough to fit everything right after startup and creating one context.
// If this test fails, we are allocating too much aside from deserialization.
- if (!Snapshot::HaveASnapshotToStartFrom()) return;
- if (Snapshot::EmbedsScript()) return;
+ if (!Snapshot::HaveASnapshotToStartFrom(CcTest::i_isolate())) return;
+ if (Snapshot::EmbedsScript(CcTest::i_isolate())) return;
CcTest::InitializeVM();
LocalContext env;
PagedSpaces spaces(CcTest::heap());
for (PagedSpace* s = spaces.next(); s != NULL; s = spaces.next()) {
uint32_t default_size = s->AreaSize();
- uint32_t reduced_size = Snapshot::SizeOfFirstPage(s->identity());
+ uint32_t reduced_size =
+ Snapshot::SizeOfFirstPage(CcTest::i_isolate(), s->identity());
if (reduced_size == default_size) continue;
int counter = 0;
Page* page = NULL;

Powered by Google App Engine
This is Rietveld 408576698