Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Unified Diff: src/snapshot.h

Issue 949623006: Attach snapshot data blob to the isolate. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/snapshot.h
diff --git a/src/snapshot.h b/src/snapshot.h
index 3135756a3252a2014c05de600f9b86a99a1d5679..dc26a11d46bcb52b4ab6d21e0d085722f1fc14b3 100644
--- a/src/snapshot.h
+++ b/src/snapshot.h
@@ -36,14 +36,18 @@ class Snapshot : public AllStatic {
Isolate* isolate, Handle<JSGlobalProxy> global_proxy,
Handle<FixedArray>* outdated_contexts_out);
- static bool HaveASnapshotToStartFrom();
+ static bool HaveASnapshotToStartFrom(Isolate* isolate) {
vogelheim 2015/02/24 15:16:31 nitpick: This (and the methods below) would concep
Yang 2015/02/25 08:19:20 Done.
+ // Do not use snapshots if the isolate is used to create snapshots.
vogelheim 2015/02/24 15:16:31 I think this comment explains the enable_serialize
Yang 2015/02/25 08:19:20 Acknowledged.
+ return isolate->snapshot_blob() != NULL;
+ }
+
+ static bool EmbedsScript(Isolate* isolate);
- static bool EmbedsScript();
+ static uint32_t SizeOfFirstPage(Isolate* isolate, AllocationSpace space);
- static uint32_t SizeOfFirstPage(AllocationSpace space);
// To be implemented by the snapshot source.
- static const v8::StartupData SnapshotBlob();
+ static const v8::StartupData* DefaultSnapshotBlob();
static v8::StartupData CreateSnapshotBlob(
const StartupSerializer& startup_ser,

Powered by Google App Engine
This is Rietveld 408576698