pkg/analysis_server/test/search/element_references_test.dart - Issue 949623005: Field references in field format parameter declarations and initializers mean writing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/test/search/element_references_test.dart

Issue 949623005: Field references in field format parameter declarations and initializers mean writing. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/search/search_engine_internal.dart ('k') | pkg/analysis_server/test/services/index/dart_index_contributor_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/test/search/element_references_test.dart

diff --git a/pkg/analysis_server/test/search/element_references_test.dart b/pkg/analysis_server/test/search/element_references_test.dart

index 538e1ee457bb61cf165ccd707cce5f61775a9453..7bcba7b617cb8ab042a910f58a1a59550263580f 100644

--- a/pkg/analysis_server/test/search/element_references_test.dart

+++ b/pkg/analysis_server/test/search/element_references_test.dart

@@ -138,6 +138,7 @@ main() {

class A {

var fff; // declaration

A(this.fff); // in constructor

+ A.named() : fff = 1;

m() {

fff = 2;

fff += 3;

@@ -154,9 +155,10 @@ main(A a) {

''');

await findElementReferences('fff; // declaration', false);

expect(searchElement.kind, ElementKind.FIELD);

- expect(results, hasLength(10));

+ expect(results, hasLength(11));

assertHasResult(SearchResultKind.DECLARATION, 'fff; // declaration');

- assertHasResult(SearchResultKind.REFERENCE, 'fff); // in constructor');

+ assertHasResult(SearchResultKind.WRITE, 'fff); // in constructor');

+ assertHasResult(SearchResultKind.WRITE, 'fff = 1;');

// m()

assertHasResult(SearchResultKind.WRITE, 'fff = 2;');

assertHasResult(SearchResultKind.WRITE, 'fff += 3;');

@@ -218,7 +220,7 @@ class A {

expect(searchElement.kind, ElementKind.FIELD);

expect(results, hasLength(4));

assertHasResult(SearchResultKind.DECLARATION, 'fff; // declaration');

- assertHasResult(SearchResultKind.REFERENCE, 'fff); // in constructor');

+ assertHasResult(SearchResultKind.WRITE, 'fff); // in constructor');

assertHasResult(SearchResultKind.WRITE, 'fff = 2;');

assertHasResult(SearchResultKind.READ, 'fff); // in m()');

}