Add recipient name to server autofill profile database

Add recipient name to server autofill profile database

This adds the recipient name to the server profile database. This was added to the schema since the original check-in.

Committed: https://crrev.com/dfbb9b2b2293b328846f870679cc59ded630fae4
Cr-Commit-Position: refs/heads/master@{#318804}

[brettw, 2015-02-25 22:30:42]

brettw@chromium.org changed reviewers:
+ estade@chromium.org

[brettw, 2015-02-25 22:56:54]

Looks like I will have to update my version to 64 to avoid colliding with your
patch.

[Evan Stade, 2015-02-25 22:58:16]

On 2015/02/25 22:56:54, brettw wrote:
> Looks like I will have to update my version to 64 to avoid colliding with your
> patch.

63 I believe, but yea, there will be a collision.

[Evan Stade, 2015-02-25 23:02:00]

lgtm aside from version number

https://codereview.chromium.org/949563003/diff/1/components/autofill/core/bro...
File components/autofill/core/browser/webdata/autofill_table.cc (right):

https://codereview.chromium.org/949563003/diff/1/components/autofill/core/bro...
components/autofill/core/browser/webdata/autofill_table.cc:1753: // The space
after language_code is necessary to make the schemas match
I don't think this comment is super necessary. Other Init*Table functions
(except the server related ones) all have a space at the end of every line
without any comment, and anyone who tries to make a breaking change will be
gently informed by a test.

[brettw, 2015-02-26 18:54:28]

https://codereview.chromium.org/949563003/diff/1/components/autofill/core/bro...
File components/autofill/core/browser/webdata/autofill_table.cc (right):

https://codereview.chromium.org/949563003/diff/1/components/autofill/core/bro...
components/autofill/core/browser/webdata/autofill_table.cc:1753: // The space
after language_code is necessary to make the schemas match
I kept it but pared it down a lot. When I was working on this file before I
"fixed" a few of these and broke stuff, so some comment seems good to me.

[Evan Stade, 2015-02-26 19:23:27]

https://codereview.chromium.org/949563003/diff/1/components/autofill/core/bro...
File components/autofill/core/browser/webdata/autofill_table.cc (right):

https://codereview.chromium.org/949563003/diff/1/components/autofill/core/bro...
components/autofill/core/browser/webdata/autofill_table.cc:1753: // The space
after language_code is necessary to make the schemas match
On 2015/02/26 18:54:28, brettw wrote:
> I kept it but pared it down a lot. When I was working on this file before I
> "fixed" a few of these and broke stuff, so some comment seems good to me.

right, but it seems unlikely people will see this comment when working on
"fixing" any other function in this file. So my preference would be adding a
more helpful error message when the test fails (if the test's current message is
not obvious enough).

just a nit, either way lgtm

[brettw, 2015-03-02 22:44:50]

The CQ bit was checked by brettw@chromium.org

[brettw, 2015-03-02 22:44:50]

The patchset sent to the CQ was uploaded after l-g-t-m from estade@chromium.org
Link to the patchset: https://codereview.chromium.org/949563003/#ps40001 (title:
" ")

[commit-bot: I haz the power, 2015-03-02 22:52:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/949563003/40001

[commit-bot: I haz the power, 2015-03-02 23:53:08]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-02 23:56:25]

Patchset 3 (id:??) landed as
https://crrev.com/dfbb9b2b2293b328846f870679cc59ded630fae4
Cr-Commit-Position: refs/heads/master@{#318804}