Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 949543002: PPAPI: Add test for new-style permission for Sockets (Closed)

Created:
5 years, 10 months ago by dmichael (off chromium)
Modified:
5 years, 10 months ago
Reviewers:
raymes
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PPAPI: Add test for new-style permission for Sockets It turns out that the permissions are working fine, but the documentation is inadequate. BUG=434430 Committed: https://crrev.com/dfffe67c00316f6c9e9be9259207df5b1ec1d29a Cr-Commit-Position: refs/heads/master@{#317719}

Patch Set 1 : #

Total comments: 4

Patch Set 2 : review comments #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -48 lines) Patch
M chrome/chrome_tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/ppapi/ppapi_browsertest.cc View 1 3 chunks +12 lines, -8 lines 0 comments Download
M ppapi/tests/extensions/extensions.gyp View 1 chunk +21 lines, -0 lines 0 comments Download
M ppapi/tests/extensions/packaged_app/controller.js View 1 1 chunk +5 lines, -4 lines 1 comment Download
M ppapi/tests/extensions/packaged_app/test_packaged_app.cc View 1 4 chunks +21 lines, -2 lines 0 comments Download
A + ppapi/tests/extensions/socket_permissions/controller.js View 1 2 chunks +3 lines, -5 lines 0 comments Download
A + ppapi/tests/extensions/socket_permissions/index.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + ppapi/tests/extensions/socket_permissions/main.js View 1 chunk +1 line, -1 line 0 comments Download
A + ppapi/tests/extensions/socket_permissions/manifest.json View 1 chunk +6 lines, -0 lines 0 comments Download
A + ppapi/tests/extensions/socket_permissions/test_socket_permissions.cc View 1 1 chunk +22 lines, -26 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
dmichael (off chromium)
5 years, 10 months ago (2015-02-20 23:48:57 UTC) #4
raymes
lgtm https://codereview.chromium.org/949543002/diff/40001/chrome/test/ppapi/ppapi_browsertest.cc File chrome/test/ppapi/ppapi_browsertest.cc (right): https://codereview.chromium.org/949543002/diff/40001/chrome/test/ppapi/ppapi_browsertest.cc#newcode1464 chrome/test/ppapi/ppapi_browsertest.cc:1464: void LaunchTestingApp(const std::string& extension_path) { nit: extension_dirname? https://codereview.chromium.org/949543002/diff/40001/ppapi/tests/extensions/socket_permissions/controller.js ...
5 years, 10 months ago (2015-02-23 00:56:11 UTC) #5
dmichael (off chromium)
https://codereview.chromium.org/949543002/diff/40001/chrome/test/ppapi/ppapi_browsertest.cc File chrome/test/ppapi/ppapi_browsertest.cc (right): https://codereview.chromium.org/949543002/diff/40001/chrome/test/ppapi/ppapi_browsertest.cc#newcode1464 chrome/test/ppapi/ppapi_browsertest.cc:1464: void LaunchTestingApp(const std::string& extension_path) { On 2015/02/23 00:56:10, raymes ...
5 years, 10 months ago (2015-02-23 23:46:38 UTC) #6
raymes
lgtm!
5 years, 10 months ago (2015-02-23 23:52:10 UTC) #7
dmichael (off chromium)
Thanks!
5 years, 10 months ago (2015-02-24 00:03:47 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/949543002/60001
5 years, 10 months ago (2015-02-24 00:05:21 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years, 10 months ago (2015-02-24 01:25:43 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 01:26:43 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/dfffe67c00316f6c9e9be9259207df5b1ec1d29a
Cr-Commit-Position: refs/heads/master@{#317719}

Powered by Google App Engine
This is Rietveld 408576698