components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h - Issue 949533004: Rename DataReductionProxyStatisticsPrefs to DataReductionProxyCompressionStats

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h

Issue 949533004: Rename DataReductionProxyStatisticsPrefs to DataReductionProxyCompressionStats (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_reduction_proxy/core/browser/data_reduction_proxy_prefs.cc ('k') | components/data_reduction_proxy/core/browser/data_reduction_proxy_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h

diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h b/components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h

index 1017e8133ef7acb850f8d23ceecd30d046f37ec2..70590d6bfb9259f02a9a299f2a10bdb0d007ddf3 100644

--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h

+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h

@@ -32,7 +32,7 @@ typedef base::Callback<void(const std::string&, const net::URLRequestStatus&)>

FetcherResponseCallback;

class DataReductionProxySettings;

-class DataReductionProxyStatisticsPrefs;

+class DataReductionProxyCompressionStats;

// Contains and initializes all Data Reduction Proxy objects that have a

@@ -46,7 +46,7 @@ class DataReductionProxyService : public base::NonThreadSafe,

// TODO(jeremyim): DataReductionProxyService should own

// DataReductionProxySettings and not vice versa.

DataReductionProxyService(

- scoped_ptr<DataReductionProxyStatisticsPrefs> statistics_prefs,

+ scoped_ptr<DataReductionProxyCompressionStats> statistics_prefs,

bengr 2015/02/27 22:43:32 You'll want to change every variable name accordin

zhuoyu.qian 2015/02/28 06:16:03 Done.

DataReductionProxySettings* settings,

net::URLRequestContextGetter* request_context_getter);

@@ -66,7 +66,7 @@ class DataReductionProxyService : public base::NonThreadSafe,

scoped_refptr<base::SequencedTaskRunner> ui_task_runner,

const base::TimeDelta& commit_delay);

- DataReductionProxyStatisticsPrefs* statistics_prefs() const {

+ DataReductionProxyCompressionStats* statistics_prefs() const {

bengr 2015/02/27 22:43:33 This function should be called compression_stats()

zhuoyu.qian 2015/02/28 06:16:03 Done.

return statistics_prefs_.get();

bengr 2015/02/27 22:43:33 compression_stats_

zhuoyu.qian 2015/02/28 06:16:03 Done.

}

@@ -92,7 +92,7 @@ class DataReductionProxyService : public base::NonThreadSafe,

FetcherResponseCallback fetcher_callback_;

// Tracks compression statistics to be displayed to the user.

- scoped_ptr<DataReductionProxyStatisticsPrefs> statistics_prefs_;

+ scoped_ptr<DataReductionProxyCompressionStats> statistics_prefs_;

DataReductionProxySettings* settings_;