Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 949443002: Upstream ChromeTab.hasPrerenderedUrl to Tab (Closed)

Created:
5 years, 10 months ago by Yaron
Modified:
5 years, 10 months ago
Reviewers:
nyquist
CC:
chromium-reviews, David Trainor- moved to gerrit, avayvod+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream ChromeTab.hasPrerenderedUrl to Tab It was just passing straight through on the native side. BUG=443773 Committed: https://crrev.com/b5c617e80b2b0c07fcd927c135f64f93ceb0f3b7 Cr-Commit-Position: refs/heads/master@{#317584}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/Tab.java View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/android/tab_android.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/android/tab_android.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Yaron
5 years, 10 months ago (2015-02-20 16:29:57 UTC) #2
nyquist
lgtm
5 years, 10 months ago (2015-02-20 18:59:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/949443002/1
5 years, 10 months ago (2015-02-23 14:16:05 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/61595)
5 years, 10 months ago (2015-02-23 14:18:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/949443002/1
5 years, 10 months ago (2015-02-23 14:26:05 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-23 14:36:12 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 14:36:35 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b5c617e80b2b0c07fcd927c135f64f93ceb0f3b7
Cr-Commit-Position: refs/heads/master@{#317584}

Powered by Google App Engine
This is Rietveld 408576698