Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 949413002: Correctly handle SurfaceDisplayOutputSurface::SwapBuffers with empty frame. (Closed)

Created:
5 years, 10 months ago by jbauman
Modified:
5 years, 9 months ago
Reviewers:
jamesr
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Correctly handle SurfaceDisplayOutputSurface::SwapBuffers with empty frame. This can happen temporarily on compositor creation, so ensure a surface is created before attempting to use it. BUG=461569, 461491 Committed: https://crrev.com/43ad5f2c3eb7466f8a08952cc5dff15931d9126e Cr-Commit-Position: refs/heads/master@{#318166}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M cc/surfaces/surface_display_output_surface.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
jbauman
5 years, 9 months ago (2015-02-26 00:47:12 UTC) #2
jamesr
lgtm
5 years, 9 months ago (2015-02-26 00:54:35 UTC) #3
jamesr
Although arguably this is a caller bug.
5 years, 9 months ago (2015-02-26 00:54:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/949413002/1
5 years, 9 months ago (2015-02-26 01:03:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-02-26 01:12:50 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-02-26 01:13:45 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/43ad5f2c3eb7466f8a08952cc5dff15931d9126e
Cr-Commit-Position: refs/heads/master@{#318166}

Powered by Google App Engine
This is Rietveld 408576698