Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Unified Diff: Source/platform/scroll/Scrollbar.cpp

Issue 949303002: Fix invalidation during painting of scrollbars (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: TestExpectations Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/scroll/Scrollbar.cpp
diff --git a/Source/platform/scroll/Scrollbar.cpp b/Source/platform/scroll/Scrollbar.cpp
index 78dc927dc3c3f8ed6c2cfff534e96bad9411c0a3..3d627d069583150c3f9ae2617b3e94bb22d87b97 100644
--- a/Source/platform/scroll/Scrollbar.cpp
+++ b/Source/platform/scroll/Scrollbar.cpp
@@ -105,6 +105,15 @@ Scrollbar::~Scrollbar()
#endif
}
+void Scrollbar::setFrameRect(const IntRect& frameRect)
+{
+ if (frameRect != this->frameRect()) {
Julien - ping for review 2015/02/25 01:43:36 We prefer early return whenever possible.
Xianzhu 2015/02/25 01:57:09 Done.
+ invalidate();
chrishtr 2015/02/24 22:38:42 Is this because widgets don't obey the standard wa
Xianzhu 2015/02/24 23:01:56 Yes. They are not LayoutObjects, so the normal pre
+ Widget::setFrameRect(frameRect);
+ invalidate();
+ }
+}
+
ScrollbarOverlayStyle Scrollbar::scrollbarOverlayStyle() const
{
return m_scrollableArea ? m_scrollableArea->scrollbarOverlayStyle() : ScrollbarOverlayStyleDefault;
« Source/core/paint/ScrollableAreaPainter.cpp ('K') | « Source/platform/scroll/Scrollbar.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698