chrome/browser/media/router/media_route_id.h - Issue 949293004: Add media router common classes and unittests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/media/router/media_route_id.h

Issue 949293004: Add media router common classes and unittests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Resync with latest changes Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_MEDIA_ROUTER_MEDIA_ROUTE_ID_H_

	6 #define CHROME_BROWSER_MEDIA_ROUTER_MEDIA_ROUTE_ID_H_

	7

	8 #include <string>

	9

	10 #include "base/callback.h"

	11

	12 namespace media_router {

	13

	14 typedef std::string MediaRouteId;
	mark a. foltz 2015/03/02 21:40:09 Any downside to placing this into media_route.h (o Any downside to placing this into media_route.h (or are there headers that need only the id declared)? mark a. foltz 2015/03/02 21:40:09 using using Kevin M 2015/03/03 21:53:19 A cycle is introduced if we fold media_route_id.h Show quoted text On 2015/03/02 21:40:09, mark a. foltz wrote: > Any downside to placing this into media_route.h (or are there headers that need > only the id declared)? A cycle is introduced if we fold media_route_id.h into media_route.h: media_route.h --depends--> media_controller.h --depends--> media_route_id.h
	15

	16 } // namespace media_router

	17

	18 #endif // CHROME_BROWSER_MEDIA_ROUTER_MEDIA_ROUTE_ID_H_

OLD	NEW