Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: chrome/browser/media/router/media_source.h

Issue 949293004: Add media router common classes and unittests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Code review feedback Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CHROME_BROWSER_MEDIA_ROUTER_MEDIA_SOURCE_H_
6 #define CHROME_BROWSER_MEDIA_ROUTER_MEDIA_SOURCE_H_
7
8 #include <string>
9
10 #include "chrome/browser/media/router/media_route_id.h"
xhwang 2015/03/05 22:28:50 not needed?
Kevin M 2015/03/06 23:12:45 Done.
11
12 namespace media_router {
13
14 using MediaSource = std::string;
15
16 // Returns MediaSource URI depending on the type of source.
17 MediaSource ForTabMediaSource(int tab_id);
18 MediaSource ForDesktopMediaSource();
19 MediaSource ForCastAppMediaSource(const std::string& app_id);
20 MediaSource ForPresentationUrl(const std::string& presentation_url);
xhwang 2015/03/05 22:28:50 nit: How about MediaSourceForTab or GetMediaSource
Kevin M 2015/03/06 23:12:45 Good suggestion, this provides better organization
21
22 bool IsMirroringMediaSource(const MediaSource& source);
23 bool IsValidMediaSource(const MediaSource& source);
24
25 } // namespace media_router
26
27 #endif // CHROME_BROWSER_MEDIA_ROUTER_MEDIA_SOURCE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698