Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Issue 949253002: Revert of Revert of cc: Increase kMaxCopyOperations to 32. (Closed)

Created:
5 years, 10 months ago by Zhenyao Mo
Modified:
5 years, 10 months ago
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of cc: Increase kMaxCopyOperations to 32. (patchset #1 id:1 of https://codereview.chromium.org/941253003/) Reason for revert: After reverting the crash is still there, likely caused by the skia roll. Created crbug.com/461399 to keep track, and relanding the reverted CL. Original issue's description: > Revert of cc: Increase kMaxCopyOperations to 32. (patchset #1 id:1 of https://codereview.chromium.org/937843006/) > > Reason for revert: > This is likely to cause a crash on the Webkit Linux MSAN bot: > > http://test-results.appspot.com/dashboards/flakiness_dashboard.html#master=ChromiumWebkit&tests=virtual/gpu/fast/canvas/canvas-path-context-clip.html > > Below is the stack: > > crash log for gpu (pid <unknown>): > STDOUT: #CRASHED - gpu > STDERR: [21350:21350:1203/112619:8509072119133:FATAL:gles2_cmd_copy_texture_chromium.cc(263)] Check failed: !buffer_id_. > STDERR: #0 0x7f2ee72e416e base::debug::StackTrace::StackTrace() > STDERR: #1 0x7f2ee737e965 logging::LogMessage::~LogMessage() > STDERR: #2 0x7f2ee598c5be gpu::CopyTextureCHROMIUMResourceManager::~CopyTextureCHROMIUMResourceManager() > STDERR: #3 0x7f2ee59e48ae base::DefaultDeleter<>::operator()() > STDERR: #4 0x7f2ee59e486b base::internal::scoped_ptr_impl<>::reset() > STDERR: #5 0x7f2ee59d467d scoped_ptr<>::reset() > STDERR: #6 0x7f2ee59b373f gpu::gles2::GLES2DecoderImpl::Destroy() > STDERR: #7 0x7f2ee2332bd9 content::GpuCommandBufferStub::Destroy() > STDERR: #8 0x7f2ee2332665 content::GpuCommandBufferStub::~GpuCommandBufferStub() > STDERR: #9 0x7f2ee2332ca9 content::GpuCommandBufferStub::~GpuCommandBufferStub() > STDERR: #10 0x7f2ee231d72e IDMap<>::Releaser<>::release() > STDERR: #11 0x7f2ee231cd4d IDMap<>::Remove() > STDERR: #12 0x7f2ee231a252 content::GpuChannel::OnDestroyCommandBuffer() > STDERR: #13 0x7f2ee231e3da DispatchToMethod<>() > STDERR: #14 0x7f2ee231e21d IPC::SyncMessageSchema<>::DispatchWithSendParams<>() > STDERR: #15 0x7f2ee231c8ad GpuChannelMsg_DestroyCommandBuffer::Dispatch<>() > STDERR: #16 0x7f2ee2319731 content::GpuChannel::OnControlMessageReceived() > STDERR: #17 0x7f2ee2318583 content::GpuChannel::HandleMessage() > STDERR: #18 0x7f2ee23208e2 base::internal::RunnableAdapter<>::Run() > STDERR: #19 0x7f2ee23207f3 base::internal::InvokeHelper<>::MakeItSo() > STDERR: #20 0x7f2ee2320795 base::internal::Invoker<>::Run() > STDERR: #21 0x7f2ee72cc5be base::Callback<>::Run() > STDERR: #22 0x7f2ee72ea7a9 base::debug::TaskAnnotator::RunTask() > STDERR: #23 0x7f2ee73a76d8 base::MessageLoop::RunTask() > STDERR: #24 0x7f2ee73a783b base::MessageLoop::DeferOrRunPendingTask() > STDERR: #25 0x7f2ee73a7a75 base::MessageLoop::DoWork() > STDERR: #26 0x7f2ee72a012e base::MessagePumpGlib::Run() > STDERR: #27 0x7f2ee73a71a2 base::MessageLoop::RunHandler() > STDERR: #28 0x7f2ee740ff94 base::RunLoop::Run() > STDERR: #29 0x7f2ee73a68e1 base::MessageLoop::Run() > STDERR: #30 0x7f2ee23bed92 content::GpuMain() > STDERR: #31 0x7f2ee142f02f content::RunNamedProcessTypeMain() > STDERR: #32 0x7f2ee14333a2 content::ContentMainRunnerImpl::Run() > STDERR: #33 0x7f2ee142e4d5 content::ContentMain() > STDERR: #34 0x00000044ec9c main > STDERR: #35 0x7f2ed82f676d __libc_start_main > STDERR: #36 0x00000044eb89 <unknown> > STDERR: > STDERR: Received signal 6 > STDERR: #0 0x7f2ee72e416e base::debug::StackTrace::StackTrace() > STDERR: #1 0x7f2ee72e3ca3 base::debug::(anonymous namespace)::StackDumpSignalHandler() > STDERR: #2 0x7f2ed86a4cb0 <unknown> > STDERR: #3 0x7f2ed830b425 gsignal > STDERR: #4 0x7f2ed830eb8b abort > STDERR: #5 0x7f2ee72e02f6 base::debug::(anonymous namespace)::DebugBreak() > STDERR: #6 0x7f2ee72e02d9 base::debug::BreakDebugger() > STDERR: #7 0x7f2ee737ecca logging::LogMessage::~LogMessage() > STDERR: #8 0x7f2ee598c5be gpu::CopyTextureCHROMIUMResourceManager::~CopyTextureCHROMIUMResourceManager() > STDERR: #9 0x7f2ee59e48ae base::DefaultDeleter<>::operator()() > STDERR: #10 0x7f2ee59e486b base::internal::scoped_ptr_impl<>::reset() > STDERR: #11 0x7f2ee59d467d scoped_ptr<>::reset() > STDERR: #12 0x7f2ee59b373f gpu::gles2::GLES2DecoderImpl::Destroy() > STDERR: #13 0x7f2ee2332bd9 content::GpuCommandBufferStub::Destroy() > STDERR: #14 0x7f2ee2332665 content::GpuCommandBufferStub::~GpuCommandBufferStub() > STDERR: #15 0x7f2ee2332ca9 content::GpuCommandBufferStub::~GpuCommandBufferStub() > STDERR: #16 0x7f2ee231d72e IDMap<>::Releaser<>::release() > STDERR: #17 0x7f2ee231cd4d IDMap<>::Remove() > STDERR: #18 0x7f2ee231a252 content::GpuChannel::OnDestroyCommandBuffer() > STDERR: #19 0x7f2ee231e3da DispatchToMethod<>() > STDERR: #20 0x7f2ee231e21d IPC::SyncMessageSchema<>::DispatchWithSendParams<>() > STDERR: #21 0x7f2ee231c8ad GpuChannelMsg_DestroyCommandBuffer::Dispatch<>() > STDERR: #22 0x7f2ee2319731 content::GpuChannel::OnControlMessageReceived() > STDERR: #23 0x7f2ee2318583 content::GpuChannel::HandleMessage() > STDERR: #24 0x7f2ee23208e2 base::internal::RunnableAdapter<>::Run() > STDERR: #25 0x7f2ee23207f3 base::internal::InvokeHelper<>::MakeItSo() > STDERR: #26 0x7f2ee2320795 base::internal::Invoker<>::Run() > STDERR: #27 0x7f2ee72cc5be base::Callback<>::Run() > STDERR: #28 0x7f2ee72ea7a9 base::debug::TaskAnnotator::RunTask() > STDERR: #29 0x7f2ee73a76d8 base::MessageLoop::RunTask() > STDERR: #30 0x7f2ee73a783b base::MessageLoop::DeferOrRunPendingTask() > STDERR: #31 0x7f2ee73a7a75 base::MessageLoop::DoWork() > STDERR: #32 0x7f2ee72a012e base::MessagePumpGlib::Run() > STDERR: #33 0x7f2ee73a71a2 base::MessageLoop::RunHandler() > STDERR: #34 0x7f2ee740ff94 base::RunLoop::Run() > STDERR: #35 0x7f2ee73a68e1 base::MessageLoop::Run() > STDERR: #36 0x7f2ee23bed92 content::GpuMain() > STDERR: #37 0x7f2ee142f02f content::RunNamedProcessTypeMain() > STDERR: #38 0x7f2ee14333a2 content::ContentMainRunnerImpl::Run() > STDERR: #39 0x7f2ee142e4d5 content::ContentMain() > STDERR: #40 0x00000044ec9c main > STDERR: #41 0x7f2ed82f676d __libc_start_main > STDERR: #42 0x00000044eb89 <unknown> > STDERR: r8: 000000000000007c r9: 0000000000500000 r10: 0000000000000008 r11: 0000000000000206 > STDERR: r12: 000000000044eb60 r13: 00007fff5e500ac0 r14: 0000000000000000 r15: 0000000000000000 > STDERR: di: 0000000000005366 si: 0000000000005366 bp: 00007fff5e4fd330 bx: 0000000000000000 > STDERR: dx: 0000000000000006 ax: 0000000000000000 cx: ffffffffffffffff sp: 00007fff5e4fd1f8 > STDERR: ip: 00007f2ed830b425 efl: 0000000000000206 cgf: 0000000000000033 erf: 0000000000000000 > STDERR: trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000 > > Original issue's description: > > cc: Increase kMaxCopyOperations to 32. > > > > Increase max number of copy operations from 16 to 32. This > > improves the throughput on systems where raster performance > > is relatively high. > > > > BUG=454898 > > > > Committed: https://crrev.com/ed9a3edff6bffc58ff37c2bd78b768062771b647 > > Cr-Commit-Position: refs/heads/master@{#317614} > > TBR=vmpstr@chromium.org,vangelis@chromium.org,reveman@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=454898 > > Committed: https://crrev.com/3649a12ed7bc7244a2d0e6970c5655544e46487f > Cr-Commit-Position: refs/heads/master@{#317661} TBR=vmpstr@chromium.org,vangelis@chromium.org,reveman@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=454898 Committed: https://crrev.com/2c6f7d3c1f353cab96869b4f8bd8da946a68d04e Cr-Commit-Position: refs/heads/master@{#317812}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M cc/resources/one_copy_tile_task_worker_pool.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Zhenyao Mo
Created Revert of Revert of cc: Increase kMaxCopyOperations to 32.
5 years, 10 months ago (2015-02-24 17:15:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/949253002/1
5 years, 10 months ago (2015-02-24 17:15:40 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-24 17:16:56 UTC) #3
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 17:17:26 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2c6f7d3c1f353cab96869b4f8bd8da946a68d04e
Cr-Commit-Position: refs/heads/master@{#317812}

Powered by Google App Engine
This is Rietveld 408576698