Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Unified Diff: chrome/BUILD.gn

Issue 949233003: Fix official build in GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@random
Patch Set: remove ppapi dep Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index ab95acd332d77b7c978bb308a9f7e4d8fade02a3..a807c09e5eea9c002c92c99d62a7944003e11293 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -294,7 +294,10 @@ if (is_win) {
# TODO(brettW) this should have more reduced visibility, but chrome/browser
# currently depends on this.
#visibility = [ ":*" ]
- source = "version.h.in"
+
+ # This one just uses the custom template and no separate sources.
+ sources = []
+ template_file = "version.h.in"
# TODO(brettw) this should move to $target_gen_dir/version.h and
# source files including it should reference it via "chrome/version.h"
@@ -302,39 +305,31 @@ if (is_win) {
}
process_version("chrome_exe_version") {
- source = "//chrome/app/chrome_version.rc.version"
- output = "$target_gen_dir/chrome_exe_version.rc"
- extra_args = [
- "-f",
- rebase_path("app/chrome_exe.ver", root_build_dir),
+ sources = [
+ "app/chrome_exe.ver",
]
+ output = "$target_gen_dir/chrome_exe_version.rc"
}
process_version("chrome_dll_version") {
- source = "//chrome/app/chrome_version.rc.version"
- output = "$target_gen_dir/chrome_dll_version.rc"
- extra_args = [
- "-f",
- rebase_path("app/chrome_dll.ver", root_build_dir),
+ sources = [
+ "app/chrome_dll.ver",
]
+ output = "$target_gen_dir/chrome_dll_version.rc"
}
process_version("nacl64_exe_version") {
- source = "//chrome/app/chrome_version.rc.version"
- output = "$target_gen_dir/nacl64_exe_version.rc"
- extra_args = [
- "-f",
- rebase_path("app/nacl64_exe.ver", root_build_dir),
+ sources = [
+ "app/nacl64_exe.ver",
]
+ output = "$target_gen_dir/nacl64_exe_version.rc"
}
process_version("other_version") {
- source = "//chrome/app/chrome_version.rc.version"
- output = "$target_gen_dir/other_version.rc"
- extra_args = [
- "-f",
- rebase_path("app/other.ver", root_build_dir),
+ sources = [
+ "app/other.ver",
]
+ output = "$target_gen_dir/other_version.rc"
}
group("chrome_version_resources") {
« no previous file with comments | « no previous file | chrome/android/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698