Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6114)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome_elf/BUILD.gn

Issue 949233003: Fix official build in GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@random
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/version.gni ('K') | « chrome/version.gni ('k') | components/data_reduction_proxy/core/common/BUILD.gn » ('j') | media/cdm/ppapi/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_elf/BUILD.gn
diff --git a/chrome_elf/BUILD.gn b/chrome_elf/BUILD.gn
index 74a217f276dd21cdfac03445aec83624bfa8b7cb..092ba7a360e63aff993e44efd88ac4dd2763c1a3 100644
--- a/chrome_elf/BUILD.gn
+++ b/chrome_elf/BUILD.gn
@@ -6,12 +6,10 @@ import("//chrome/version.gni")
import("//testing/test.gni")
process_version("chrome_elf_resources") {
- source = "//chrome/app/chrome_version.rc.version"
- output = "$target_gen_dir/chrome_elf_version.rc"
- extra_args = [
- "-f",
- rebase_path("chrome_elf.ver"),
+ sources = [
+ "chrome_elf.ver",
]
Dirk Pranke 2015/02/25 00:23:19 nit: is this formatted properly?
+ output = "$target_gen_dir/chrome_elf_version.rc"
}
shared_library("chrome_elf") {
« chrome/version.gni ('K') | « chrome/version.gni ('k') | components/data_reduction_proxy/core/common/BUILD.gn » ('j') | media/cdm/ppapi/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698