chrome/chrome_watcher/BUILD.gn - Issue 949233003: Fix official build in GN

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_watcher/BUILD.gn

Issue 949233003: Fix official build in GN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@random

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/chrome_watcher/BUILD.gn

diff --git a/chrome/chrome_watcher/BUILD.gn b/chrome/chrome_watcher/BUILD.gn

index 376daaab68f17205e73a98518faa0b9abe327081..db5f5e8cd37b5d15b7c1012a729b158d6fd1e593 100644

--- a/chrome/chrome_watcher/BUILD.gn

+++ b/chrome/chrome_watcher/BUILD.gn

@@ -15,12 +15,10 @@ source_set("client") {

}

process_version("chrome_watcher_resources") {

- source = "//chrome/app/chrome_version.rc.version"

- output = "$target_gen_dir/chrome_watcher_version.rc"

- extra_args = [

- "-f",

- rebase_path("chrome_watcher.ver", root_build_dir),

+ sources = [

Dirk Pranke 2015/02/25 00:23:19 Is this formatted correctly? I'd expect this to be

brettw 2015/02/25 00:51:32 sources and deps are always multi-line.

+ "chrome_watcher.ver",

]

+ output = "$target_gen_dir/chrome_watcher_version.rc"

}

shared_library("chrome_watcher") {