Issue 949233002: Do not propagate empty value for face attribute

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 949233002: Do not propagate empty value for face attribute (Closed)

Created:
5 years, 10 months ago by rwlbuis

Modified:
5 years, 10 months ago

Reviewers:
Timothy Loh

CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Do not propagate empty value for face attribute The testcase causes the face attribute to be null. This is a problem for the HashMap in CSSValuePool, but actually empty/null values should not be propagated at all in the first place. BUG=456717 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190788

Patch Set 1 #

Patch Set 2 : Add test #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
A	LayoutTests/fast/css/font-face-attribute-remove.html	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
A +	LayoutTests/fast/css/font-face-attribute-remove-expected.html	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	Source/core/html/HTMLFontElement.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/949233002/20001

5 years, 10 months ago (2015-02-25 00:14:54 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-25 01:34:42 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190788

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages