Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1000)

Unified Diff: Source/core/html/HTMLMediaElement.h

Issue 949203002: Separate the text track container from the media controls (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: same size as media controls Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLMediaElement.h
diff --git a/Source/core/html/HTMLMediaElement.h b/Source/core/html/HTMLMediaElement.h
index 96c5c4054f2001b4832412fc4ded06c28db3dd8d..5b3420561b9322152d83d1b6ca33a66854871feb 100644
--- a/Source/core/html/HTMLMediaElement.h
+++ b/Source/core/html/HTMLMediaElement.h
@@ -58,6 +58,7 @@ class MediaController;
class MediaControls;
class MediaError;
class HTMLMediaSource;
+class TextTrackContainer;
class TextTrackList;
class TimeRanges;
class URLRegistry;
@@ -414,6 +415,9 @@ private:
void ensureMediaControls();
void configureMediaControls();
+ TextTrackContainer* textTrackContainer() const;
philipj_slow 2015/02/26 09:51:52 Oops, will remove this.
fs 2015/02/26 12:30:51 I'd hope it should be possible to remove the one b
philipj_slow 2015/02/27 07:32:44 Who would be responsible for creating and insertin
fs 2015/02/27 09:50:31 It would still be the HTMLMediaElement doing that,
philipj_slow 2015/02/27 10:00:01 OK, that sounds good with some imaginary salt :)
+ TextTrackContainer& ensureTextTrackContainer();
+
virtual void* preDispatchEventHandler(Event*) override final;
void changeNetworkStateFromLoadingToIdle();

Powered by Google App Engine
This is Rietveld 408576698