Separate the text track container from the media controls

Source/core/html/track/TextTrackContainer.cpp

Index: Source/core/html/track/TextTrackContainer.cpp
diff --git a/Source/core/html/track/TextTrackContainer.cpp b/Source/core/html/track/TextTrackContainer.cpp
index d2c4a08146eb02017f59302bb93bb5f743e91ce7..c5d0b2e5d0e751f9de6f1dbfbf4ce0d7f5efbb70 100644
--- a/Source/core/html/track/TextTrackContainer.cpp
+++ b/Source/core/html/track/TextTrackContainer.cpp
@@ -45,7 +45,6 @@ PassRefPtrWillBeRawPtr<TextTrackContainer> TextTrackContainer::create(Document&
 {
     RefPtrWillBeRawPtr<TextTrackContainer> element = adoptRefWillBeNoop(new TextTrackContainer(document));
     element->setShadowPseudoId(AtomicString("-webkit-media-text-track-container", AtomicString::ConstructFromLiteral));
-    element->setInlineStyleProperty(CSSPropertyDisplay, CSSValueNone);
     return element.release();
 }
 
@@ -82,9 +81,7 @@ void TextTrackContainer::updateDisplay(HTMLMediaElement& mediaElement)
     // a user interface for video, but now it is, let reset be true. Otherwise,
     // let reset be false.
 
-    // There is nothing to be done explicitly for 4th and 5th steps, as
-    // everything is handled through CSS. The caption box is on top of the
-    // controls box, in a container set with the -webkit-box display property.
+    // TODO(philipj): Implement step 4 and 5.
 
     // 6. Let tracks be the subset of video's list of text tracks that have as
     // their rules for updating the text track rendering these rules for
@@ -119,10 +116,6 @@ void TextTrackContainer::updateDisplay(HTMLMediaElement& mediaElement)
     }
 
     // 11. Return output.

[sof, 2015/03/20 08:02:14]

Unmoored comment.

[philipj_slow, 2015/03/20 15:26:11]

Thanks, I have added two comments explaining why this all looks a bit odd.

-    if (hasChildren())
-        removeInlineStyleProperty(CSSPropertyDisplay);
-    else
-        setInlineStyleProperty(CSSPropertyDisplay, CSSValueNone);
 }
 
 } // namespace blink