Separate the text track container from the media controls

Source/core/layout/LayoutMedia.cpp

 /*
  * Copyright (C) 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 35 matching lines @@
 {
     return toHTMLMediaElement(node());
 }
 
 void LayoutMedia::layout()
 {
     LayoutSize oldSize = contentBoxRect().size();
 
     LayoutImage::layout();
 
-    LayoutBox* controlsRenderer = toLayoutBox(m_children.firstChild());
-    if (!controlsRenderer)
-        return;
-
-    bool controlsNeedLayout = controlsRenderer->needsLayout();
     LayoutSize newSize = contentBoxRect().size();
-    if (newSize == oldSize && !controlsNeedLayout)
-        return;
 
     LayoutState state(*this, locationOffset());
 
-    controlsRenderer->setLocation(LayoutPoint(borderLeft(), borderTop()) + LayoutSize(paddingLeft(), paddingTop()));
-    controlsRenderer->style()->setHeight(Length(newSize.height(), Fixed));
-    controlsRenderer->style()->setWidth(Length(newSize.width(), Fixed));
-    controlsRenderer->forceLayout();
+    for (LayoutObject* child = m_children.firstChild(); child; child = child->nextSibling()) {
+        ASSERT(child->node()->isMediaControls() || child->node()->isTextTrackContainer());
+
+        if (newSize == oldSize && !child->needsLayout())
+            continue;
+
+        LayoutBox* layoutBox = toLayoutBox(child);
+        layoutBox->setLocation(LayoutPoint(borderLeft(), borderTop()) + LayoutSize(paddingLeft(), paddingTop()));
+        layoutBox->style()->setHeight(Length(newSize.height(), Fixed));

[fs, 2015/03/20 09:51:01]

Should probably use "mutableStyleRef" here to avoid tripping the LayoutStyle
constification effort. Accompanied by a TODO to try and get rid of it =)

[philipj_slow, 2015/03/20 15:26:11]

Done.

+        layoutBox->style()->setWidth(Length(newSize.width(), Fixed));
+        layoutBox->forceLayout();
+    }
+
     clearNeedsLayout();
 }
 
 bool LayoutMedia::isChildAllowed(LayoutObject* child, const LayoutStyle&) const
 {
-    // The only allowed child is the media controls. The user agent stylesheet
-    // (mediaControls.css) has ::-webkit-media-controls { display: flex; }. If
-    // author style sets display: inline we would get an inline renderer as a
-    // child of replaced content, which is not supposed to be possible. This
-    // check can be removed if ::-webkit-media-controls is made internal.
-    return child->isFlexibleBox();
+    // Two types of child layout objects are allowed: media controls
+    // and the text track container. Filter children by node type.
+    ASSERT(child->node());
+
+    // The user agent stylesheet (mediaControls.css) has
+    // ::-webkit-media-controls { display: flex; }. If author style
+    // sets display: inline we would get an inline renderer as a child
+    // of replaced content, which is not supposed to be possible. This
+    // check can be removed if ::-webkit-media-controls is made
+    // internal.
+    if (child->node()->isMediaControls())
+        return child->isFlexibleBox();
+
+    if (child->node()->isTextTrackContainer())
+        return true;
+
+    return false;
 }
 
 void LayoutMedia::paintReplaced(const PaintInfo&, const LayoutPoint&)
 {
 }
 
 } // namespace blink