[bindings] Remove SQLTransaction's usage of custom binding.

Source/modules/webdatabase/SQLTransaction.cpp

 /*
  * Copyright (C) 2007, 2008, 2013 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 251 matching lines @@
     m_backend->requestTransitToState(m_nextState);
     return SQLTransactionState::Idle;
 }
 
 void SQLTransaction::performPendingCallback()
 {
     computeNextStateAndCleanupIfNeeded();
     runStateMachine();
 }
 
-void SQLTransaction::executeSQL(const String& sqlStatement, const Vector<SQLValue>& arguments, SQLStatementCallback* callback, SQLStatementErrorCallback* callbackError, ExceptionState& exceptionState)
+void SQLTransaction::executeSql(const String& sqlStatement, const Nullable<Vector<ScriptValue>>& arguments, SQLStatementCallback* callback, SQLStatementErrorCallback* callbackError, ExceptionState& exceptionState)
 {
     if (!m_executeSqlAllowed) {
         exceptionState.throwDOMException(InvalidStateError, "SQL execution is disallowed.");
         return;
     }
 
     if (!m_database->opened()) {
         exceptionState.throwDOMException(InvalidStateError, "The database has not been opened.");
         return;
     }
 
     int permissions = DatabaseAuthorizer::ReadWriteMask;
     if (!m_database->databaseContext()->allowDatabaseAccess())
         permissions |= DatabaseAuthorizer::NoAccessMask;
     else if (m_readOnly)
         permissions |= DatabaseAuthorizer::ReadOnlyMask;
 
+    Vector<SQLValue> sqlArguments;
+    if (!arguments.isNull()) {
+        const Vector<ScriptValue>& args = arguments.get();
+        for (unsigned i = 0; i < args.size(); ++i) {
+            v8::Local<v8::Value> arg = args[i].v8Value();

[jsbell, 2015/03/03 18:33:14]

Can we factor this out into toSQLValue(const ScriptValue&) ?

Also, per discussion in https://codereview.chromium.org/972153002/ I'd be in
favor of putting that in a helper library in bindings/v8/modules.

[haraken, 2015/03/04 02:00:07]

Sounds nice to put the function into IDBBindingUtilities.cpp.

[bashi, 2015/03/04 03:33:02]

Is is possible to use toImplArray()? (You need to write
NativeValueTraits<SQLValue>)

+            if (arg.IsEmpty() || arg->IsNull()) {
+                sqlArguments.append(SQLValue());
+            } else if (arg->IsNumber()) {
+                sqlArguments.append(SQLValue(arg->NumberValue()));

[bashi, 2015/03/04 03:33:02]

FYI, NumberValue() is going to be deprecated.
NumberValue(v8::Local<v8::Context>) is the new API, and I'm working on adding
macros which do empty checks.

+            } else {
+                TOSTRING_VOID(V8StringResource<>, stringValue, arg);
+                sqlArguments.append(SQLValue(stringValue));
+            }
+        }
+    }
     SQLStatement* statement = SQLStatement::create(m_database.get(), callback, callbackError);
-    m_backend->executeSQL(statement, sqlStatement, arguments, permissions);
+    m_backend->executeSQL(statement, sqlStatement, sqlArguments, permissions);
+}
+
+void SQLTransaction::executeSql(const String& sqlStatement, ExceptionState& exceptionState)
+{
+    executeSql(sqlStatement, Vector<ScriptValue>(), nullptr, nullptr, exceptionState);
 }
 
 bool SQLTransaction::computeNextStateAndCleanupIfNeeded()
 {
     // Only honor the requested state transition if we're not supposed to be
     // cleaning up and shutting down:
     if (m_database->opened()) {
         setStateToRequestedState();
         ASSERT(m_nextState == SQLTransactionState::End
             || m_nextState == SQLTransactionState::DeliverTransactionCallback
@@ skipping 18 matching lines @@
     m_successCallback.clear();
     m_errorCallback.clear();
 }
 
 SQLTransactionErrorCallback* SQLTransaction::releaseErrorCallback()
 {
     return m_errorCallback.release();
 }
 
 } // namespace blink