Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Side by Side Diff: Source/modules/webdatabase/InspectorDatabaseAgent.cpp

Issue 949193002: [bindings] Remove SQLTransaction's usage of custom binding. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Adding null check for arguments. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
152 { 152 {
153 visitor->trace(m_requestCallback); 153 visitor->trace(m_requestCallback);
154 SQLTransactionCallback::trace(visitor); 154 SQLTransactionCallback::trace(visitor);
155 } 155 }
156 156
157 virtual bool handleEvent(SQLTransaction* transaction) override 157 virtual bool handleEvent(SQLTransaction* transaction) override
158 { 158 {
159 if (!m_requestCallback->isActive()) 159 if (!m_requestCallback->isActive())
160 return true; 160 return true;
161 161
162 Vector<SQLValue> sqlValues;
163 SQLStatementCallback* callback = StatementCallback::create(m_requestCall back.get()); 162 SQLStatementCallback* callback = StatementCallback::create(m_requestCall back.get());
164 SQLStatementErrorCallback* errorCallback = StatementErrorCallback::creat e(m_requestCallback.get()); 163 SQLStatementErrorCallback* errorCallback = StatementErrorCallback::creat e(m_requestCallback.get());
165 transaction->executeSQL(m_sqlStatement, sqlValues, callback, errorCallba ck, IGNORE_EXCEPTION); 164 transaction->executeSql(m_sqlStatement, Vector<ScriptValue>(), callback, errorCallback, IGNORE_EXCEPTION);
166 return true; 165 return true;
167 } 166 }
168 private: 167 private:
169 TransactionCallback(const String& sqlStatement, PassRefPtrWillBeRawPtr<Execu teSQLCallback> requestCallback) 168 TransactionCallback(const String& sqlStatement, PassRefPtrWillBeRawPtr<Execu teSQLCallback> requestCallback)
170 : m_sqlStatement(sqlStatement) 169 : m_sqlStatement(sqlStatement)
171 , m_requestCallback(requestCallback) { } 170 , m_requestCallback(requestCallback) { }
172 String m_sqlStatement; 171 String m_sqlStatement;
173 RefPtrWillBeMember<ExecuteSQLCallback> m_requestCallback; 172 RefPtrWillBeMember<ExecuteSQLCallback> m_requestCallback;
174 }; 173 };
175 174
(...skipping 165 matching lines...) Expand 10 before | Expand all | Expand 10 after
341 340
342 DEFINE_TRACE(InspectorDatabaseAgent) 341 DEFINE_TRACE(InspectorDatabaseAgent)
343 { 342 {
344 #if ENABLE(OILPAN) 343 #if ENABLE(OILPAN)
345 visitor->trace(m_resources); 344 visitor->trace(m_resources);
346 #endif 345 #endif
347 InspectorBaseAgent::trace(visitor); 346 InspectorBaseAgent::trace(visitor);
348 } 347 }
349 348
350 } // namespace blink 349 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698