Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 949093002: InlinedVisitor: Migrate encryptedmedia to use inlined tracing (Closed)

Created:
5 years, 10 months ago by kouhei (in TOK)
Modified:
5 years, 10 months ago
CC:
blink-reviews, feature-media-reviews_chromium.org, philipj_slow, eric.carlson_apple.com
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

InlinedVisitor: Migrate encryptedmedia to use inlined tracing Updates trace methods as of https://groups.google.com/a/chromium.org/d/msg/blink-dev/oi4Snt9jNx8/XcES55c7QaQJ R=oilpan-reviews BUG=455524 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190725

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -26 lines) Patch
M Source/modules/encryptedmedia/ContentDecryptionModuleResultPromise.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/encryptedmedia/ContentDecryptionModuleResultPromise.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/encryptedmedia/EncryptedMediaRequest.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/encryptedmedia/MediaEncryptedEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/encryptedmedia/MediaEncryptedEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/encryptedmedia/MediaKeyMessageEvent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/encryptedmedia/MediaKeyMessageEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/encryptedmedia/MediaKeySession.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/encryptedmedia/MediaKeySession.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/encryptedmedia/MediaKeyStatusMap.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/encryptedmedia/MediaKeyStatusMap.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/encryptedmedia/MediaKeySystemAccess.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/encryptedmedia/MediaKeySystemAccess.cpp View 1 chunk +1 line, -1 line 1 comment Download
M Source/modules/encryptedmedia/MediaKeys.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/encryptedmedia/MediaKeys.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/modules/encryptedmedia/MediaKeysController.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
kouhei (in TOK)
5 years, 10 months ago (2015-02-24 06:58:17 UTC) #2
tkent
lgtm
5 years, 10 months ago (2015-02-24 07:35:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/949093002/1
5 years, 10 months ago (2015-02-24 07:36:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=190725
5 years, 10 months ago (2015-02-24 08:35:30 UTC) #7
haraken
5 years, 10 months ago (2015-02-24 08:38:17 UTC) #9
Message was sent while issue was closed. 
LGTM

https://codereview.chromium.org/949093002/diff/1/Source/modules/encryptedmedi...
File Source/modules/encryptedmedia/MediaKeySystemAccess.cpp (right):

https://codereview.chromium.org/949093002/diff/1/Source/modules/encryptedmedi...
Source/modules/encryptedmedia/MediaKeySystemAccess.cpp:148:
DEFINE_TRACE(MediaKeySystemAccess)

You can inline this.

Powered by Google App Engine
This is Rietveld 408576698