Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: third_party/sqlite/src/test/ioerr2.test

Issue 949043002: Add //third_party/sqlite to dirs_to_snapshot, remove net_sql.patch (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/sqlite/src/test/ioerr.test ('k') | third_party/sqlite/src/test/ioerr4.test » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/sqlite/src/test/ioerr2.test
diff --git a/third_party/sqlite/src/test/ioerr2.test b/third_party/sqlite/src/test/ioerr2.test
index 325c0baded41ec5b817f96a3a33f3ade2baf2865..c08c3453f3077fd543dd7a0bc179c19777cbc0f8 100644
--- a/third_party/sqlite/src/test/ioerr2.test
+++ b/third_party/sqlite/src/test/ioerr2.test
@@ -112,6 +112,12 @@ foreach bPersist [list 0 1] {
}
}
+# When this test was written, an IO error within the UPDATE statement caused
+# a rollback, which tripped all read-cursors, causing the outer SELECT to
+# fail with "abort due to ROLLBACK". Now, the loop continues until the UPDATE
+# is run successfully. At this point the next IO error occurs within the
+# SELECT - throwing the "disk I/O error" that the test case now expects.
+#
do_test ioerr2-5 {
execsql {
CREATE TABLE t2 AS SELECT * FROM t1;
@@ -130,7 +136,7 @@ do_test ioerr2-5 {
}
} msg]
list $rc $msg
-} {1 {callback requested query abort}}
+} {1 {disk I/O error}} ;# used to be "{1 {abort due to ROLLBACK}}"
if {$::tcl_platform(platform) == "unix"} {
# Cause the call to xAccess used by [pragma temp_store_directory] to
« no previous file with comments | « third_party/sqlite/src/test/ioerr.test ('k') | third_party/sqlite/src/test/ioerr4.test » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698