Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: BUILD.gn

Issue 949003003: Disable app_shell_unittests on the mac GN builds for now. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index c03435e11187936a04aff8be2396e272fc79a3b7..124e0ff9244f670d35fe8c084e8f88057cad336c 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -144,7 +144,8 @@ group("root") {
]
deps += root_extra_deps
- if (enable_extensions) {
+ # TODO(GYP): Get this working on the mac?
+ if (enable_extensions && !is_mac) {
deps += [ "//extensions/shell:app_shell_unittests" ]
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698